{{ message }}
Add auto install script - #1701
Merged
Merged
Conversation
nhooyr
force-pushed
the
auto-install
branch
3 times, most recently
from
May 20, 2020 13:11
c2230c4 to
7e50de2
Compare
Contributor
Author
nhooyr
force-pushed
the
auto-install
branch
2 times, most recently
from
May 20, 2020 13:18
b6684bd to
a3033bc
Compare
Contributor
Author
|
Need to add to README.md and guide.md In the next release we'll add installation over SSH support and then deprecate sshcode. |
nhooyr
force-pushed
the
auto-install
branch
2 times, most recently
from
May 20, 2020 13:21
18164f7 to
4e8b1b8
Compare
nhooyr
marked this pull request as ready for review
May 20, 2020 13:29
Contributor
Author
|
Contributor
Author
|
code-asher
reviewed
May 20, 2020
code-asher
left a comment
code-asher
left a comment
Member
There was a problem hiding this comment.
This is dope. Love the dry run.
Member
|
Agreed about the long option names, those are my preference in general. Fetching the latest version also seems like a good idea. |
Contributor
Author
|
And check for libc and libcxx #1706 |
Contributor
Author
|
@code-asher Please re-review the new changes. Last thing I need to take care of is #1706 |
Contributor
Author
kylecarbs
approved these changes
May 21, 2020
nhooyr
force-pushed
the
auto-install
branch
2 times, most recently
from
May 22, 2020 02:22
4bfc7fb to
1a195c5
Compare
Closes #1726
More clear as discussed in PR.
code-asher
reviewed
May 27, 2020
code-asher
approved these changes
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.