chore(flight): feedback implementation by codejockie · Pull Request #27 · codejockie/document-manager · GitHub
Skip to content

chore(flight): feedback implementation#27

Merged
codejockie merged 3 commits into
masterfrom
chore/149807877/feedback-implementation
Aug 4, 2017
Merged

chore(flight): feedback implementation#27
codejockie merged 3 commits into
masterfrom
chore/149807877/feedback-implementation

Conversation

@codejockie

Copy link
Copy Markdown
Owner

#149807877 feedback implementation

#### What does this PR do?
#### This PR implements all feedback received during defense

#### Description of Tasks to be completed
#### N/A

#### How should this be manually tested?
#### N/A

#### Any background context you want to provide?
#### No

#### What are the relevant pivotal tracker stories?
#### Feedback Implementation

#### Screenshots (if appropriate)
#### None

#### Questions:
#### None

@codejockie codejockie temporarily deployed to cjdocs-pr-27 August 3, 2017 16:13 Inactive

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../server/models' import/no-unresolved
Missing file extension for "../../server/models" import/extensions

import { expect } from 'chai';
import supertest from 'supertest';
import app from '../../src/server';
import models from '../../server/models';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../server/models' import/no-unresolved
Missing file extension for "../../server/models" import/extensions

import supertest from 'supertest';
import app from '../../src/server';
import models from '../../server/models';
import { hashPassword } from '../../server/helpers/helper';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../server/helpers/helper' import/no-unresolved
Missing file extension for "../../server/helpers/helper" import/extensions

import { expect } from 'chai';
import supertest from 'supertest';
import app from '../../src/server';
import models from '../../server/models';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../server/models' import/no-unresolved
Missing file extension for "../../server/models" import/extensions

@@ -0,0 +1,354 @@
import { expect } from 'chai';
import supertest from 'supertest';
import app from '../../src/server';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../src/server' import/no-unresolved
Missing file extension for "../../src/server" import/extensions

Comment thread server/routes/search.js
import express from 'express';
import { formatDate } from '../helpers/helper';
import searchController from '../controllers/search';
import { validateQuery } from '../middleware/middleware';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../middleware/middleware' import/no-unresolved
Missing file extension for "../middleware/middleware" import/extensions

Comment thread server/routes/search.js
@@ -1,102 +1,12 @@
import express from 'express';
import { formatDate } from '../helpers/helper';
import searchController from '../controllers/search';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../controllers/search' import/no-unresolved
Missing file extension for "../controllers/search" import/extensions

Comment thread server/routes/roles.js Outdated
@@ -0,0 +1,15 @@
import rolesController from '../controllers/roles';
import { authenticate, isAdministrator, validateParam, validateRole } from '../middleware/middleware';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../middleware/middleware' import/no-unresolved
Missing file extension for "../middleware/middleware" import/extensions

Comment thread server/routes/roles.js
@@ -0,0 +1,15 @@
import rolesController from '../controllers/roles';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../controllers/roles' import/no-unresolved
Missing file extension for "../controllers/roles" import/extensions

Comment thread server/routes/index.js

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './users' import/no-unresolved
Missing file extension for "./users" import/extensions

@codejockie codejockie temporarily deployed to cjdocs-pr-27 August 3, 2017 17:44 Inactive
add a helper to generate document/user responses
add helper to find document/role/user by id

Fixes #149807877
@codejockie codejockie merged commit 7b9c6bf into master Aug 4, 2017
@codejockie codejockie deleted the chore/149807877/feedback-implementation branch May 18, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants