iframe-proxy

codejockie · 2017-07-26T16:09:30Z

#149490791 remove redundant packages

#### What does this PR do?
#### This PR removes unused packages and useless import statements

#### Description of Tasks to be completed
#### None

#### How should this be manually tested?
#### None

#### Any background context you want to provide?
#### No

#### What are the relevant pivotal tracker stories?
#### Remove Redundant Packages and Imports

#### Screenshots (if appropriate)
#### None

#### Questions:
#### None

install moment Start #149490791

uninstall unused packages edit users update route edit documents get all route Finishes #149490791

houndci-bot · 2017-07-26T16:09:44Z

@@ -1,5 +1,4 @@
-import chai, { expect } from 'chai';
-import chaiHttp from 'chai-http';
+import { expect } from 'chai';


Unable to resolve path to module 'chai' import/no-unresolved
Missing file extension for "chai" import/extensions

houndci-bot · 2017-07-26T16:09:44Z

@@ -1,5 +1,4 @@
-import chai, { expect } from 'chai';
-import chaiHttp from 'chai-http';
+import { expect } from 'chai';


Unable to resolve path to module 'chai' import/no-unresolved
Missing file extension for "chai" import/extensions

houndci-bot · 2017-07-26T16:09:44Z

@@ -1,5 +1,4 @@
-import chai, { expect } from 'chai';
-import chaiHttp from 'chai-http';
+import { expect } from 'chai';


Unable to resolve path to module 'chai' import/no-unresolved
Missing file extension for "chai" import/extensions

houndci-bot · 2017-07-26T16:09:44Z

 import express from 'express';
 import _ from 'lodash';
-import { hashPassword, isAdmin, isUser } from '../helpers/helper';
+import { formatDate, hashPassword, isAdmin, isUser } from '../helpers/helper';


Unable to resolve path to module '../helpers/helper' import/no-unresolved
Missing file extension for "../helpers/helper" import/extensions

houndci-bot · 2017-07-26T16:09:44Z

@@ -1,5 +1,5 @@
 import express from 'express';
-import { isAdmin, isUser } from '../helpers/helper';
+import { formatDate, isAdmin, isUser } from '../helpers/helper';


Unable to resolve path to module '../helpers/helper' import/no-unresolved
Missing file extension for "../helpers/helper" import/extensions

houndci-bot · 2017-07-26T16:09:45Z

@@ -1,13 +1,38 @@
 import bcrypt from 'bcryptjs';
+import moment from 'moment';


Unable to resolve path to module 'moment' import/no-unresolved
Missing file extension for "moment" import/extensions

coveralls · 2017-07-26T16:17:34Z

Coverage decreased (-0.3%) to 86.97% when pulling 5883c70 on chore/149490791/remove-useless-packages into da4e429 on master.

BolajiOlajide · 2017-07-26T16:24:02Z

Your PR name is somehow. 🤣
Try Chore/149490791/remove redundant packages. No package is useless lol

BolajiOlajide · 2017-07-26T16:24:55Z

   +  Delete documents, users
   +  Update documents, users
-
-## Endpoints


Is there any reason you removed this, I think it's important because how do I know what routes are available and the HTTP method to use.

There's a documentation available at root of the url @ http://cjdocs.herokuapp.com

If I wanted to contribute to your project, I'd be hurt if I didn't see it in your README. The README is like a developers go-to source for information about a project. The more descriptive, the better.

I agree, but the feedback a friend got during his defense said to remove it. That was why I removed it.

BolajiOlajide · 2017-07-26T16:25:51Z

+ * @param {string} date The date to format
+ * @returns {Date} Date
+ */
+export function formatDate(date) {


any reason you're not complying with ES6 standard here. You could easily export const formatDate = (date) => { here.

Just a thought.

I'm following the Airbnb style guide, which say prefer normal function for things like that

Can you share a link to where you found that, will love to see how they put it.

It's from ESLint, but I can check for it. Encountered it when I was working on a React app in CP1

I think it's here https://github.com/airbnb/javascript#functions

I feel you are safer using arrow functions instead.

It's just a suggestion though.

codejockie added 2 commits July 26, 2017 17:04

chore(finish): install moment

a1a8a49

install moment Start #149490791

chore(finish): remove useless packages

5883c70

uninstall unused packages edit users update route edit documents get all route Finishes #149490791

houndci-bot reviewed Jul 26, 2017

View reviewed changes

BolajiOlajide reviewed Jul 26, 2017

View reviewed changes

codejockie changed the title ~~Chore/149490791/remove useless packages~~ Chore/149490791/remove redundant packages Jul 26, 2017

codejockie merged commit ab5731b into master Jul 27, 2017

codejockie deleted the chore/149490791/remove-useless-packages branch May 18, 2018 11:31

		@@ -1,13 +1,38 @@
		import bcrypt from 'bcryptjs';
		import moment from 'moment';

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

codejockie commented Jul 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jul 26, 2017

Uh oh!

BolajiOlajide commented Jul 26, 2017

Uh oh!

BolajiOlajide Jul 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codejockie Jul 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codejockie commented Jul 26, 2017 •

edited

Loading

BolajiOlajide Jul 26, 2017 •

edited

Loading

codejockie Jul 26, 2017 •

edited

Loading