feat: `shield:setup` does Email setup by kenjis · Pull Request #876 · codeigniter4/shield · GitHub
Skip to content

feat: shield:setup does Email setup#876

Merged
kenjis merged 16 commits into
codeigniter4:developfrom
kenjis:feat-setup-command-email-setup
Oct 7, 2023
Merged

feat: shield:setup does Email setup#876
kenjis merged 16 commits into
codeigniter4:developfrom
kenjis:feat-setup-command-email-setup

Conversation

@kenjis

@kenjis kenjis commented Oct 3, 2023

Copy link
Copy Markdown
Member

Needs #871

Description

  • shield:setup does Email setup
  • refactor

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the enhancement New feature or request label Oct 3, 2023
@kenjis kenjis marked this pull request as draft October 3, 2023 05:17
@kenjis kenjis force-pushed the feat-setup-command-email-setup branch 2 times, most recently from b7b0321 to 9ae74a0 Compare October 3, 2023 20:21
@datamweb datamweb marked this pull request as ready for review October 3, 2023 20:27
@datamweb datamweb added the stale Pull requests with conflicts label Oct 3, 2023
@datamweb datamweb marked this pull request as draft October 3, 2023 20:27
@kenjis kenjis force-pushed the feat-setup-command-email-setup branch from 9ae74a0 to a7ad37e Compare October 3, 2023 20:35
@kenjis kenjis marked this pull request as ready for review October 3, 2023 20:40
@kenjis kenjis removed the stale Pull requests with conflicts label Oct 3, 2023
Comment thread src/Commands/BaseCommand.php
@datamweb

datamweb commented Oct 3, 2023

Copy link
Copy Markdown
Collaborator

@datamweb datamweb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@kenjis kenjis merged commit 112ba2a into codeigniter4:develop Oct 7, 2023
@kenjis kenjis deleted the feat-setup-command-email-setup branch October 7, 2023 22:43
@kenjis

kenjis commented Oct 7, 2023

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants