feat: improve user experience in forms by sammyskills · Pull Request #801 · codeigniter4/shield · GitHub
Skip to content

feat: improve user experience in forms#801

Merged
kenjis merged 4 commits into
codeigniter4:developfrom
sammyskills:feat-improve-ux
Aug 29, 2023
Merged

feat: improve user experience in forms#801
kenjis merged 4 commits into
codeigniter4:developfrom
sammyskills:feat-improve-ux

Conversation

@sammyskills

Copy link
Copy Markdown
Contributor

Currently, when filling forms, there is no indication of the field being filled (or what is expected of the user) after a user has entered value in the input fields. If a user forgets what was in the placeholder before filling the form, s/he will need to delete the entire entry in the input to know what the field expects. See screenshot below:

image

This PR improves user experience by providing a floating label to indicate the field that is being filled. See screenshot below:

image

@sammyskills

Copy link
Copy Markdown
Contributor Author

@datamweb datamweb added the enhancement New feature or request label Aug 26, 2023
Comment thread src/Views/email_activate_show.php Outdated

@datamweb datamweb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I am against the views becoming crowded. The reason for this is that I believe that every website should have its own customized views, and it is usually easier to copy paste and edit simple files.

However, I understand what your goal is with this PR. So except for the one I mentioned, everything looks good.

Thanks for the screenshot.

@sammyskills

Copy link
Copy Markdown
Contributor Author

In general, I am against the views becoming crowded. The reason for this is that I believe that every website should have its own customized views, and it is usually easier to copy paste and edit simple files.

I understand your concern but it may surprise you to know that some of the websites that use shield, use the auth views the same way it is.

Currently, the views are built using bootstrap framework and a lot of websites use the same framework. So if there will be changes, it will be minimal.

Do you remember someone suggested that dark mode feature should be added to the views #772 ?

@datamweb datamweb closed this Aug 26, 2023
@datamweb datamweb reopened this Aug 26, 2023
Comment thread src/Language/fa/Auth.php Outdated
@datamweb

Copy link
Copy Markdown
Collaborator

but it may surprise you to know that some of the websites that use shield, use the auth views the same way it is.

Yes, I know, probably we could have done much better in terms of education.
Worse than this, I see that many websites provide services to users in development mode.

Do you remember someone suggested that dark mode feature should be added to the views #772 ?

I was silent there too. Probably, if someone else had sent this PR, I would not have given these explanations. Anyway, there should be a difference between the answer to the user who has already been with the Shield and the new user who wants to be added recently.

Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>

@datamweb datamweb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sammyskills thank you!

@sammyskills

sammyskills commented Aug 26, 2023

Copy link
Copy Markdown
Contributor Author

I was silent there too. Probably, if someone else had sent this PR, I would not have given these explanations. Anyway, there should be a difference between the answer to the user who has already been with the Shield and the new user who wants to be added recently.

I get your point @datamweb.

There are some suggestions that are totally out of the scope of shield, but, I also know that there are some that will serve as a foundation or example to any tweak that will be done by developers.

As developers, I know it is sometimes hard to think about user experience, but, believe me, it is very vital.

@kenjis

kenjis commented Aug 27, 2023

Copy link
Copy Markdown
Member

Thank you. This is good. Because it is better to add label for input.
PhpStorm always warns these.
Screenshot 2023-08-27 11 48 38

Comment thread src/Language/ja/Auth.php Outdated
Co-authored-by: kenjis <kenji.uui@gmail.com>
@sammyskills sammyskills requested a review from kenjis August 27, 2023 07:38
@kenjis

kenjis commented Aug 29, 2023

Copy link
Copy Markdown
Member

@kenjis kenjis merged commit b6d327d into codeigniter4:develop Aug 29, 2023
@sammyskills sammyskills deleted the feat-improve-ux branch August 29, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants