{{ message }}
feat: Change session manipulation methods from private to protected#1113
Merged
Conversation
datamweb
approved these changes
May 3, 2024
kenjis
reviewed
May 6, 2024
kenjis
reviewed
May 6, 2024
kenjis
reviewed
May 6, 2024
Member
Member
Author
|
The methods related to the user session will give us about 50 lines of code. I don't see the point of moving them to a separate class - especially if they are to remain non-public. |
kenjis
approved these changes
May 13, 2024
Member
|
The session data manipulation is needed only for the Session authenticator. By the way, is this an enhancement or a bug fix? |
Member
Author
|
I would say this is an enhancement. |
michalsn
changed the title
private to protectedprivate to protected
Member
|
Then it should be released as v1.1.0. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the session manipulation methods from
privatetoprotected, so we can use them if we extend theAuthentication\Authenticators\Sessionclass.Reference: #1111
Checklist: