Change Oracle image by kenjis · Pull Request #18 · codeigniter4/.github · GitHub
Skip to content

Change Oracle image#18

Merged
kenjis merged 1 commit into
mainfrom
change-oracle-image
Oct 13, 2023
Merged

Change Oracle image#18
kenjis merged 1 commit into
mainfrom
change-oracle-image

Conversation

@kenjis

@kenjis kenjis commented Oct 12, 2023

Copy link
Copy Markdown
Member

Description
Fixes codeigniter4/shield#899

See codeigniter4/CodeIgniter4#6755
See https://github.com/gvenzl/oci-oracle-xe#github-actions

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis force-pushed the change-oracle-image branch from 3473bfa to 06a45e8 Compare October 12, 2023 22:46

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this entirely but I see it works and trust your research.

@kenjis

kenjis commented Oct 13, 2023

Copy link
Copy Markdown
Member Author

@kenjis kenjis merged commit f137f97 into main Oct 13, 2023
@kenjis kenjis deleted the change-oracle-image branch October 13, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing with OCI8 always fails

3 participants