{{ message }}
Repository navigation
Conversation
slug and title now in getstatic or getserverside props!!!!
oohwooh
self-requested a review
March 17, 2023 20:04
oohwooh
reviewed
Mar 17, 2023
oohwooh
left a comment
oohwooh
left a comment
Member
There was a problem hiding this comment.
looks good at initial glance. We still need to test CRUD form functionality before merge, and I am currently too tired to trust myself to test that adequately.
Contributor
Author
Contributor
Author
Nexite
marked this pull request as draft
March 22, 2023 17:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title and slug properties now set in getstaticprops or getserverside props. prevents re-rendering the component every time (this stops duplicate requests for contributors in footer and increases performance).
Also moved moment-timezone out of _app, reduced first load js by about 50kB.
Switching to nextjs compatible links should make pages load faster and makes user experience much smoother!