Repository navigation
Conversation
Realized the extraneous work being done in findMatching.ts and removed that Added more metrics to matchingHelpers.ts Created more robust data typing in matchingTypes.ts Created more simple way to test the algorithm's implementation
… it multiple times to find the best solutions.
|
A few more follow up questions!
|
…edback and needs additional testing before ready for review.
|
|
Ok cool! I've created the response with the Also, I've gone and re-named all the old "Matching" stuff (related to elastic and things) to "Recommendation". I think this is a better name and should reduce confusion between the two types, although editing the GraphQL names of these may cause issues and I'm not sure how to deal with that properly in GraphQL so I may need to put those back. Can you advise on this? |
|
This looks great to me, I have to change the queries in www-labs before merging however |

Hey yall! Want to make a PR to track the rest of the progress on this, since I'm going to need some more specific feedback to make much more progress.
Todo / status:
That should be just about everything left to do! I'd like to chat sometime soon with one or both of you about the rest of this, whoever would be the most applicable.