{{ message }}
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
SSL Support#17
Merged
Merged
Conversation
Member
Author
yannicschroeer
approved these changes
Apr 8, 2023
yannicschroeer
left a comment
yannicschroeer
left a comment
Contributor
There was a problem hiding this comment.
LGTM aside the tests 😄
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We actually don't have to implement anything on our own for SSL support, however I added the option to pass keyword arguments to the DB Engine in the
DatabaseSetupconstructor (which is a good idea anyways I guess). With psycopg2, you can also just require SSL via query parameter in the DB URI, but specifying it in the engine config is also valid.Changelog:
DatabaseSetupconstructorI had to do a bit of refactoring of the integration tests since adding table classes multiple times messed up the table medatata, but nothing big
resolves #7