[4/4] lab2-studio-oceans: docs, Rails verification, follow-ups by stephenliang · Pull Request #73496 · code-dot-org/code-dot-org · GitHub
Skip to content

[4/4] lab2-studio-oceans: docs, Rails verification, follow-ups#73496

Draft
stephenliang wants to merge 2 commits into
stephen/lab2-studio-oceans-pr3from
stephen/lab2-studio-oceans-pr4
Draft

[4/4] lab2-studio-oceans: docs, Rails verification, follow-ups#73496
stephenliang wants to merge 2 commits into
stephen/lab2-studio-oceans-pr3from
stephen/lab2-studio-oceans-pr4

Conversation

@stephenliang

@stephenliang stephenliang commented Jun 25, 2026

Copy link
Copy Markdown
Member

Verified signed-out and signed-in flows against Rails backend (milestone POST creates UserLevel row). Updated architecture docs, added @code-dot-org/lab README, and documented 6 follow-up items. Client-side nav fixes: layout fill, document title, overflow.

Lab2-studio-oceans tasks §5–6. No Rails changes.

Stack: [1/4] #73487 → [2/4] #73488 → [3/4] #73490[4/4] ← this PR

Links

  • Design: openspec/changes/lab2-studio-oceans/design.md (on proposal branch)
  • Follow-ups: frontend/apps/studio/docs/lab2-studio-oceans-followups.md

Testing story

  • Verified against Rails: signed-out anonymous flow, signed-in milestone persistence
  • Architecture docs reviewed for accuracy against implementation
  • yarn typecheck + ./tools/hooks/pre-commit pass

Deployment notes

Standard merge-and-deploy. Documentation and minor layout fixes only.

🤖 Generated with Claude Code

@stephenliang stephenliang force-pushed the stephen/lab2-studio-oceans-pr4 branch 2 times, most recently from db26ea9 to d24c4fb Compare June 25, 2026 21:20
@stephenliang stephenliang force-pushed the stephen/lab2-studio-oceans-pr3 branch from 9eeadf0 to f34b4e8 Compare June 25, 2026 21:29
@stephenliang stephenliang force-pushed the stephen/lab2-studio-oceans-pr4 branch 2 times, most recently from d14027f to a1c8c34 Compare June 25, 2026 21:35
@stephenliang stephenliang force-pushed the stephen/lab2-studio-oceans-pr3 branch from f34b4e8 to 06f3069 Compare June 25, 2026 21:35
@stephenliang stephenliang force-pushed the stephen/lab2-studio-oceans-pr4 branch from a1c8c34 to caf0b87 Compare June 25, 2026 21:58
@stephenliang stephenliang force-pushed the stephen/lab2-studio-oceans-pr3 branch from 06f3069 to 1e3b228 Compare June 25, 2026 21:58
@stephenliang stephenliang force-pushed the stephen/lab2-studio-oceans-pr4 branch from caf0b87 to b9b3098 Compare June 25, 2026 23:54
@stephenliang stephenliang force-pushed the stephen/lab2-studio-oceans-pr3 branch from 190b262 to 3584e9c Compare June 26, 2026 02:56
stephenliang and others added 2 commits June 25, 2026 19:57
Update studio architecture doc with course route structure (loader
flow, onContinue milestone + navigation, resolveLabEntrypoint).
Add @code-dot-org/lab README documenting exports, architecture rules,
and the no-store constraint. Document six follow-up items for
post-launch work (store layer, progress bar, anonymous migration,
API consolidation, lint restriction, rich error page).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use TanStack Router Link for prev/next navigation (no full reload)
- Flex column layout from root to level route so oceans fills viewport
- Set document.title from resolved level data (scriptTitle)
- Clip overflowing word buttons on level 8 with overflow:hidden
- Mock Link in LevelNavigation tests to avoid router context dependency

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant