{{ message }}
test(geolocation): pass country code instead of IP in test helpers#73481
Open
stephenliang wants to merge 2 commits into
Open
test(geolocation): pass country code instead of IP in test helpers#73481stephenliang wants to merge 2 commits into
stephenliang wants to merge 2 commits into
Conversation
… cookie If the cookie value is a 2-letter uppercase ISO 3166-1 alpha-2 code (e.g. 'ES'), set HTTP_CLOUDFRONT_VIEWER_COUNTRY directly and skip Geocoder entirely. This eliminates intermittent failures when ipinfo.io's unauthenticated free tier returns empty results. IP-address values still route through the existing Geocoder path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update Cucumber and Playwright geolocation helpers to pass 'ES' (country code) instead of '150.214.39.255' (IP address), using the country-code fast path added in the parent commit. This eliminates the Geocoder.search() call that intermittently fails in CI. Depends on: #73478 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
artem-vavilov
approved these changes
Jun 25, 2026
Base automatically changed from
stephen/geolocation-country-code-fast-path
to
staging
June 25, 2026 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"I am in Europe"to pass'ES'(country code) instead of'150.214.39.255'(IP address).setCountryOverride()helper to accept a required{countryCode}named arg (no default), setting the cookie directly.setCountryOverride(page, {countryCode: 'ES'}).Depends on
#73478 (backend: accept country code directly in GeolocationOverride cookie) — must merge first.
Test plan
🤖 Generated with Claude Code