{{ message }}
release-25.4: sql/catalog/lease: accept ABORT_REASON_CLIENT_REJECT in deadline test#169000
Open
spilchen wants to merge 1 commit intocockroachdb:release-25.4from
Open
release-25.4: sql/catalog/lease: accept ABORT_REASON_CLIENT_REJECT in deadline test#169000spilchen wants to merge 1 commit intocockroachdb:release-25.4from
spilchen wants to merge 1 commit intocockroachdb:release-25.4from
Conversation
TestLeaseTxnDeadlineExtensionWithSession expects COMMIT to fail with RETRY_COMMIT_DEADLINE_EXCEEDED, but the txnCoordSender heartbeat can race ahead and surface ABORT_REASON_CLIENT_REJECT instead. Both prove the txn was correctly prevented from committing, so accept either. Closes cockroachdb#168540 Epic: none Release note: None Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
spilchen
force-pushed
the
blathers/backport-release-25.4-168973
branch
from
7073ba7 to
5544e4e
Compare
blathers-crl
Bot
added
blathers-backport
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
blathers-crl
Bot
added
backport
Member
blathers-crl
Bot
added
the
backport-test-only
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #168973 on behalf of @spilchen.
TestLeaseTxnDeadlineExtensionWithSession expects COMMIT to fail with RETRY_COMMIT_DEADLINE_EXCEEDED, but the txnCoordSender heartbeat can race ahead and surface ABORT_REASON_CLIENT_REJECT instead. Both prove the txn was correctly prevented from committing, so accept either.
Closes #168540
Epic: none
Release note: None
Release justification: