{{ message }}
logictest: replace default configs with metamorphic meta configs#168983
Draft
msbutler wants to merge 1 commit intocockroachdb:masterfrom
Draft
logictest: replace default configs with metamorphic meta configs#168983msbutler wants to merge 1 commit intocockroachdb:masterfrom
msbutler wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Previously, a logictest using the default config set ran 13 times across 13 separate static configs. This was excessive and wasteful of CI resources. Replace the 13-config default set with 3 metamorphic meta configs that randomly choose config knobs per test file: - local-meta (1 node, DistSQL off): 50% legacy schema changer, 50% vectorize off, 50% prepared stmts, 50% disk spilling, 25/25/50 read-committed/repeatable-read/serializable isolation, 50% tenant. - 3node-meta (3 nodes, DistSQL on): same knobs as local-meta plus 50% fake span resolver. - local-mixed-meta (1 node): randomly picks one of local-mixed-25.4, local-mixed-26.1, or local-mixed-26.2 (1/3 each). Each resolved config populates an EquivalentConfigs list so that skipif/onlyif config directives in test files continue to work correctly (e.g. skipif config local-legacy-schema-changer fires when the meta config randomly enables the legacy schema changer). The metamorphic choices vary per test file within a CI run and across stress iterations, providing broad coverage with fewer runs. Epic: none Release note: None
Contributor
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the 13-config default logictest config set with 3 metamorphic
meta configs that randomly choose config knobs per test file:
changer, vectorize off, prepared stmts, disk spilling, isolation
levels, and secondary tenant mode.
resolver.
version configs.
Each resolved config populates an
EquivalentConfigslist so thatskipif/onlyif configdirectives continue to work. The metamorphicchoices vary per test file within a CI run and across stress iterations.
Epic: none
Release note: None