slurm.conf.example: Filter out more Slurm node state flags#469
Conversation
There was a problem hiding this comment.
I hope Slurm supports UTF-8, as it will eventually exhaust us-ascii special characters... ;)
Wondering if you should not have a different strategy, where you filter only keeping the standard characters and remove all the other ones?
There was a problem hiding this comment.
I can't wait for emoji-based node states :)
But more seriously, I think the filtering should ideally not be based on what Slurm states strings could contain. but rather on what is considered acceptable characters in a group name, namely not those: https://github.com/cea-hpc/clustershell/blob/a1875cb78dc5f579e7053dae9bbcd848cc1c3a1f/lib/ClusterShell/NodeSet.py#L74
But I'm not sure we can get that illegal characters list in a group configuration file, can we?
kcgthb
changed the title
* filter out the following characters from the node states returned by sinfo: *~#!%$@+^- Slurm 21.08 introduced a new node state flag (^), and we missed a few before. See https://slurm.schedmd.com/sinfo.html#SECTION_NODE-STATE-CODES for a complete list.
degremont
left a comment
degremont
left a comment
There was a problem hiding this comment.
Based on the discussion, i'm ok with the current patch
3 participants
Slurm 21.08 introduced a new node state flag (^), and we missed a few before.
See https://slurm.schedmd.com/sinfo.html#SECTION_NODE-STATE-CODES for a complete list