{{ message }}
updateMember function refactored to accept tabs#1
Open
soe wants to merge 2 commits into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 files (routes/index.js and libs/cloudspokes.js) are changed in refactoring updateMember function.
"updateMember" function is modified to accept 1 more param: memberTabs which is retrieved from DocuSign API.
Please refer to change log here: https://github.com/soe/Docusign-Embedded-Signing/compare/cs2026
In the following gist (https://gist.github.com/4599566#file-tabs-json-output), "tabs" returned in JSON output from DocuSign API response is included for reference.
** Demo: http://docusign-soe.herokuapp.com/sign/a0IZ0000000FyJU/jeffdonthemic/99097A71-5EE0-43DD-A16F-6D0066983910/jdouglas@appirio.com
** Screencast: https://vimeo.com/57982065
tabs to fields mapping
Tabs reference: https://gist.github.com/4599566#file-tabs-json-output
Code reference: https://github.com/soe/Docusign-Embedded-Signing/compare/cs2026#L0R46
Tabs can be mapped out to member's fields inside if/else block.