{{ message }}
Repository navigation
Conversation
wadlejitendra
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
November 14, 2022 10:19
wadlejitendra
force-pushed
the
dev/986
branch
2 times, most recently
from
November 15, 2022 08:29
62672a4 to
917a067
Compare
gbartolini
reviewed
Nov 15, 2022
Contributor
There was a problem hiding this comment.
@wadlejitendra why don't we then remove the superuser code?
Contributor
There was a problem hiding this comment.
Given that the scope of this ticket is to remove support from version 1.19, please make sure that we remove the setting of superuser in streaming_replica which was required in Postgres 10.
Contributor
|
@wadlejitendra with this patch we officially remove support for PostgreSQL 10 from CloudNativePG version 1.19. So please remove anything that introduces exceptions in the code to work with Postgres 10. |
armru
force-pushed
the
dev/986
branch
2 times, most recently
from
November 28, 2022 10:01
9cde22e to
ad1f088
Compare
armru
approved these changes
Nov 29, 2022
sxd
approved these changes
Nov 29, 2022
Signed-off-by: Jitendra Wadle <jitendra.wadle@enterprisedb.com>
Signed-off-by: Jitendra Wadle <jitendra.wadle@enterprisedb.com>
Signed-off-by: Jitendra Wadle <jitendra.wadle@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Contributor
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes : #986
Signed-off-by: Jitendra Wadle jitendra.wadle@enterprisedb.com