{{ message }}
Repository navigation
Conversation
This adds type declarations for RPC methods implemented by the Flagship service. The change is additive, and the existing get() method remains available with a deprecation notice, so no compatibility flag is needed.
6 tasks done
edmundhung
reviewed
Oct 19, 2026
Member
There was a problem hiding this comment.
Is there any context you can share about deprecating this API? It's quite rare we deprecate an API on a binding, so just wanna learn more about the case here.
Member
There was a problem hiding this comment.
AFAIK Record<string, unknown> cannot be used to match an interface and this would fail:
interface Config { theme: string }
const fallback: Config = { theme: "light" };
flags.getObjectValue("config", fallback); // accepted
flags.getValue("config", fallback); // TypeScript error
flags.getDetails("config", fallback); // TypeScript error
karishnu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies
The configuration version lets the Flagship OpenFeature provider invalidate cached binding evaluations without maintaining a background stream in Worker isolates.
Test plan
just generate-typesbazel test //types:test/types/flagship