{{ message }}
vmm: api: Fix image_type in OpenAPI definition#7734
Merged
rbradford merged 1 commit intocloud-hypervisor:mainfrom Feb 21, 2026
Merged
vmm: api: Fix image_type in OpenAPI definition#7734rbradford merged 1 commit intocloud-hypervisor:mainfrom
rbradford merged 1 commit intocloud-hypervisor:mainfrom
Conversation
Signed-off-by: Wei Liu <liuwe@microsoft.com>
Member
Author
likebreath
reviewed
Feb 21, 2026
| image_type: | ||
| type: enum ["FixedVhd", "Qcow2", "Raw", "Vhdx"] | ||
| type: string | ||
| enum: [FixedVhd, Qcow2, Raw, Vhdx, Unknown] |
Member
There was a problem hiding this comment.
We had a discussion on this during the code review from the private fork. Since the openapi validator test passed, we thought it would be valid and a stricter syntax... cc @rbradford
Member
Right. This needs backporting. |
likebreath
approved these changes
Feb 21, 2026
@liuw , @likebreath , Kata is working for me again after this change. When the revised v51 will become available, I will pick it up into Kata. Thanks! |
rbradford
approved these changes
Feb 21, 2026
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is reported OpenAPI tool handles this snippet wrong.
The code generator tool doesn’t complain, generates code that uses a hypothetical enum type, but then it doesn’t define that enum:
Change the definition to follow how other enums are define. The example we use is the state field under VmInfo.
We should backport this to v50 and v51.