vmm: improve UUID parse err and --net fd help by Coffeeri · Pull Request #7702 · cloud-hypervisor/cloud-hypervisor · GitHub
Skip to content

vmm: improve UUID parse err and --net fd help#7702

Merged
rbradford merged 2 commits intocloud-hypervisor:mainfrom
Coffeeri:minor-improvements
Feb 13, 2026
Merged

vmm: improve UUID parse err and --net fd help#7702
rbradford merged 2 commits intocloud-hypervisor:mainfrom
Coffeeri:minor-improvements

Conversation

@Coffeeri
Copy link
Copy Markdown
Contributor

This PR contains two small improvements:

  1. Include the invalid UUID string in SMBIOS UUID parse errors.
  2. Fix --net help text to document the correct FD list syntax as shown is working within the by test_net_parsing test.

@Coffeeri Coffeeri requested a review from a team as a code owner February 13, 2026 12:43
Copy link
Copy Markdown
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

On-behalf-of: SAP leander.kohler@sap.com
Signed-off-by: Leander Kohler <leander.kohler@cyberus-technology.de>
The --net help text documented fd as fd=<fd1,fd2...>, but
comma-separated FD lists in option values must be bracketed to avoid
top-level option splitting.

Update NetConfig::SYNTAX to use fd=<[fd1,fd2,...]>, matching parser
behavior and existing net parsing tests:
`cargo test -p vmm test_net_parsing`

On-behalf-of: SAP leander.kohler@sap.com
Signed-off-by: Leander Kohler <leander.kohler@cyberus-technology.de>
@rbradford rbradford added this pull request to the merge queue Feb 13, 2026
Merged via the queue into cloud-hypervisor:main with commit 30c86d5 Feb 13, 2026
43 checks passed
@Coffeeri Coffeeri deleted the minor-improvements branch February 15, 2026 14:53
@github-project-automation github-project-automation Bot moved this from 🆕 New to ✅ Done in Cloud Hypervisor Roadmap Feb 19, 2026
@likebreath likebreath added the bug-fix Bug fix to include in release notes label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Bug fix to include in release notes

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants