{{ message }}
This repository was archived by the owner on Nov 6, 2025. It is now read-only.
Support JVM toolchain for Clojure tasks#185
Merged
Merged
Conversation
675a889 to
edb8540
Compare
Allow all Clojure tasks to specify a JavaLauncher. This is part of Gradle's JVM toolchain [1] feature allowing decoupling the JVM version Gradle uses from the JVM used for tasks. Now all tasks Clojurephant provides have a common base interface ClojureTask the support fork options and java launcher. This also picks up the JavaToolchain on the JavaPluginExtension and applies it by default to all ClojureTasks. Fixes #174 [1] https://docs.gradle.org/current/userguide/toolchains.html Add JavaLauncher to all tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Allow all Clojure tasks to specify a JavaLauncher. This is part of Gradle's JVM toolchain [1] feature allowing decoupling the JVM version Gradle uses from the JVM used for tasks.
Now all tasks Clojurephant provides have a common base interface ClojureTask the support fork options and java launcher.
This also picks up the JavaToolchain on the JavaPluginExtension and applies it by default to all ClojureTasks.
Fixes #174
[1] https://docs.gradle.org/current/userguide/toolchains.html
Add JavaLauncher to all tasks
Related issues:
Contributor Checklist
patch:if the change added no new functionality and is backwards compatibleminor:if the change added new functionality and is backwards compatiblemajor:if the change is not backwards compatiblechore:if the change doesn't affect plugin logic/behavior at all (and obviously still backwards compatible)patch(clojurescript):)builddocsclojureclojurescriptcommonreplclojurephant-plugin/src/compatTest)docs/)./gradlew check)TIP: If troubleshooting a CI failure, look for the build scan URL in the workflow run summary.