{{ message }}
[stacktrace] Repatriate stacktrace analyzer from Haystack#322
Merged
Conversation
alexander-yakushev
force-pushed
the
stacktrace-analyzer
branch
from
f60e651 to
0920bb8
Compare
alexander-yakushev
force-pushed
the
stacktrace-analyzer
branch
2 times, most recently
from
b06d34f to
9967858
Compare
bbatsov
reviewed
Mar 8, 2025
Member
There was a problem hiding this comment.
Maybe you can expand this a bit, to be more in line with the level of high-level descriptions that most other namespaces have.
bbatsov
reviewed
Mar 8, 2025
| (is (not (:data (first causes2)))))) | ||
|
|
||
| (deftest compilation-errors-test | ||
| (is (match? #"Syntax error compiling at \(.*orchard/stacktrace_test\.clj:" |
Member
There was a problem hiding this comment.
I prefer to have all assertions in testing, so that the output is a bit more descriptive, but it's not a big deal.
Member
|
Looks pretty good to me overall. |
alexander-yakushev
force-pushed
the
stacktrace-analyzer
branch
2 times, most recently
from
3580b84 to
39f5083
Compare
alexander-yakushev
force-pushed
the
stacktrace-analyzer
branch
from
39f5083 to
0189ce4
Compare
Member
Author
|
Done. |
Member
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings
haystack.analyzerback home to Orchard. This is not an exact copy; I also did a lot of work in rewriting it to make leaner and faster.The next step will be to switch cider-nrepl to this. I suspect that as I start working on that, I'll have to make some fixes here too; but I think it's fine to review and merge the current state first.