Fix PR checkout panic when base repo is not in remotes by williammartin · Pull Request #9992 · cli/cli · GitHub
Skip to content

Fix PR checkout panic when base repo is not in remotes#9992

Merged
williammartin merged 1 commit into
trunkfrom
wm/fix-pr-checkout-panic
Dec 3, 2024
Merged

Fix PR checkout panic when base repo is not in remotes#9992
williammartin merged 1 commit into
trunkfrom
wm/fix-pr-checkout-panic

Conversation

@williammartin

@williammartin williammartin commented Dec 2, 2024

Copy link
Copy Markdown
Member

Description

Fixes #9990

This uses the host from the repo for the Git credential pattern instead of the host from Git remotes to fix #9990

@BagToad BagToad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I added a description to the PR to make this easier to understand the purpose at a glance, hope that is okay 😁

@williammartin williammartin merged commit 7c241cf into trunk Dec 3, 2024
@williammartin williammartin deleted the wm/fix-pr-checkout-panic branch December 3, 2024 13:04
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 5, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cli/cli](https://github.com/cli/cli) | patch | `v2.63.0` -> `v2.63.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>cli/cli (cli/cli)</summary>

### [`v2.63.1`](https://github.com/cli/cli/releases/tag/v2.63.1): GitHub CLI 2.63.1

[Compare Source](cli/cli@v2.63.0...v2.63.1)

#### What's Changed

-   Fix formatting in `git/client_test.go` comments for linter by [@&#8203;BagToad](https://github.com/BagToad) in cli/cli#9969
-   Bump github.com/gabriel-vasile/mimetype from 1.4.6 to 1.4.7 by [@&#8203;dependabot](https://github.com/dependabot) in cli/cli#9942
-   Clarify which commands correspond to which DNF version under Linux install instructions by [@&#8203;BagToad](https://github.com/BagToad) in cli/cli#9976
-   When renaming an existing remote as part of remote creation in `gh repo fork`, log the change by [@&#8203;timrogers](https://github.com/timrogers) in cli/cli#9983
-   Fix MR checkout panic when base repo is not in remotes by [@&#8203;williammartin](https://github.com/williammartin) in cli/cli#9992

#### Security

-   A security vulnerability has been identified in GitHub CLI that could create or overwrite files in unintended directories when users download a malicious GitHub Actions workflow artifact through `gh run download`.

    For more information, see GHSA-2m9h-r57g-45pj

**Full Changelog**: cli/cli@v2.63.0...v2.63.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pr checkout panics when targeting a PR in a repo not in remotes

3 participants