{{ message }}
Repository navigation
Refreshable tokens: bump cli/oauth to v1.3.0 and fix gh status column width - #14768
Merged
Merged
Conversation
babakks
requested review from
BagToad
and
a balanced review from Copilot
and removed request for
a team and
Copilot
October 20, 2026 16:40
babakks
added this pull request to stack #14457
October 20, 2026 16:41
babakks
force-pushed
the
babakks/refresh-token-bump-deps
branch
from
October 21, 2026 09:42
04b3929 to
831b934
Compare
babakks
changed the title
gh status column width
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Runtime validation of the authentication dependency upgrade remains unverified and needs human confirmation.
1 open issue
What changed in this PR
Updates the refreshable-token stack to the released OAuth library and restores status column alignment after the Lip Gloss v2 migration.
Changes:
- Upgrade cli/oauth to v1.3.0 and convert token durations to stored seconds.
- Update documentation and tests for refresh-token reuse.
- Restore status column width and expected output.
Review effort: Balanced
babakks
force-pushed
the
babakks/refresh-token-bump-deps
branch
from
October 21, 2026 09:46
831b934 to
b38159e
Compare
williammartin
approved these changes
Oct 21, 2026
babakks
force-pushed
the
babakks/refresh-token-bump-deps
branch
11 times, most recently
from
October 21, 2026 11:56
128b7c6 to
15e431d
Compare
cli/oauth v1.3.0 exposes the access and refresh token expiry fields as time.Duration values, so convert them when building the stored credential. Refresh now keeps the previous refresh token when the server omits a new one, which the godoc and the omitted refresh token test reflect. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac178b5a-5b62-49bd-9e83-4796c7ddec46
Lip Gloss v2 includes borders in Width, which made the bordered left column one cell narrower and wrapped truncated rows. Widen it by one cell and restore the original test expectations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ac178b5a-5b62-49bd-9e83-4796c7ddec46
babakks
force-pushed
the
babakks/refresh-token-bump-deps
branch
from
October 21, 2026 12:06
15e431d to
6ec1ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR sits on top of #14752 in the refreshable-token stack. Until now the stack pinned a pre-release pseudo-version of
cli/oauth. The changes are now released, so this moves gh to the tagged version:github.com/cli/oauthv1.3.0: the token expiry fields are nowtime.Durationvalues, sointernal/authflowconverts them when building the stored credential.Refreshalso keeps the previous refresh token when the server omits a new one, which the godoc and the related test now reflect.github.com/cli/go-gh/v2v2.17.0 is already on trunk via #14148. As expected, that release was a breaking change for gh because it moved its markdown package to Glamour v2 (cli/go-gh#281), and #14148 took care of the migration.This PR also fixes a small
gh statusregression from that migration. Lip Gloss v2 counts borders withinWidth, so the bordered left column became one cell narrower than the right one and truncated rows wrapped onto a second line. The left column is now one cell wider, and thestatus_test.goexpectations are restored to what they were before #14148.How did you test this change?
Not tested by hand. I have not run
gh statusor the auth commands interactively against this branch.Key points
gh statusfix is unrelated to oauth, but it is small and keeps the go-gh/Glamour follow-up in one place before release.Notes for reviewers
Start with
internal/authflow/refresh.gofor the oauth change, thenpkg/cmd/status/status.gofor the one-line width fix. Thestatus_test.godiff only moves the column divider back by one cell and unwraps the truncated rows.Authorship and follow-up
Who wrote this:
Who answers review comments: