{{ message }}
Fix discussion acceptance test flags - #14321
Merged
williammartin merged 1 commit intoSep 2, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3950afa6-8c3e-4ae0-9654-ec5d9d64fcb6
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused test updates match the command validation and preserve the intended coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Updates discussion acceptance tests to comply with the mutually exclusive --comments and --json flags.
Changes:
- Removes
--commentsfrom four JSON assertions. - Preserves standalone human-readable comment coverage.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
babakks
approved these changes
Sep 2, 2026
williammartin
marked this pull request as ready for review
September 2, 2026 13:20
williammartin
enabled auto-merge
September 2, 2026 13:20
williammartin
disabled auto-merge
September 2, 2026 13:28
williammartin
deleted the
williammartin-fix-discussion-acceptance-tests
branch
September 2, 2026 13:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to #14215
Description
PR #14215 made
--commentsand--jsonmutually exclusive for discussion views, but four discussion acceptance-test commands still passed both flags. Remove--commentsfrom those JSON assertions because requesting thecommentsJSON field already fetches the full comment data.How did you test this change?
Key points
The standalone
--commentsacceptance case remains unchanged so human-readable comment output is still covered.Notes for reviewers
Start with
acceptance/testdata/discussion/discussion-comment.txtar. PR #14215 introduced the mutual exclusion that exposed these stale commands.Authorship and follow-up
Who wrote this:
Who answers review comments: