{{ message }}
Repository navigation
Support nested skill discovery without skills directories - #13894
Draft
tommaso-moro wants to merge 4 commits into
Draft
tommaso-moro wants to merge 4 commits into
tommaso-moro wants to merge 4 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates gh skills discovery and related command flows to support repositories where SKILL.md files live in arbitrarily nested, non-hidden directories (without requiring a skills/ directory), while preserving existing conventions (namespaced, plugins, root, hidden dirs) and ensuring installations/search results remain unambiguous when duplicate leaf names exist.
Changes:
- Expand skill discovery to match nested
<category>/<skill>/SKILL.mdlayouts and update “no skills found” messaging accordingly. - Preserve exact repository paths through search result deduplication and installation, and disambiguate duplicates in interactive prompts/errors.
- Add/adjust tests for nested discovery, ambiguity handling, and installation argument behavior.
Show a summary per file
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Low
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ccf2a058-7f75-4f53-a39d-dc9225ef5c85
tommaso-moro
force-pushed
the
tommaso-moro-skill-install-nested-discovery
branch
from
July 31, 2026 09:22
3288946 to
8f44336
Compare
This comment was marked as spam.
This comment was marked as spam.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Root-level discovery, duplicate-path handling, preview ambiguity, and ref parsing remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (3)
Comment on lines
+490
to
+495
| if !hasHiddenSegment(entry.Path) && !hasPluginsAncestor(entry.Path) && skillName != "skills" && skillName != "plugins" { | ||
| convention := "nested" | ||
| if parentDir == "." { | ||
| convention = "root" | ||
| } | ||
| return &skillMatch{entry: entry, name: skillName, skillDir: dir, convention: convention} |
Comment on lines
+490
to
+495
| if !hasHiddenSegment(entry.Path) && !hasPluginsAncestor(entry.Path) && skillName != "skills" && skillName != "plugins" { | ||
| convention := "nested" | ||
| if parentDir == "." { | ||
| convention = "root" | ||
| } | ||
| return &skillMatch{entry: entry, name: skillName, skillDir: dir, convention: convention} |
Comment on lines
+620
to
+624
| func cutSkillVersion(s string) (name, version string, found bool) { | ||
| if i := strings.LastIndex(s, "@"); i > 0 { | ||
| version = s[i+1:] | ||
| if version != "" && !strings.Contains(version, "/") { | ||
| return s[:i], version, true |
BagToad
marked this pull request as draft
September 23, 2026 21:49
Member
|
👋 moving this to draft to represent state w/ new copilot review instructions, please mark ready for review when addressed 🙏 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13876
Summary
SKILL.mdfiles whose parent directories appear at arbitrary non-hidden repository depths, without requiring askills/directory.API request impact
SKILL.mddescriptions and repository metadata. Enrichment remains capped atpage * limit * 3candidates (45 with the default first page).Testing
go test ./...makegolangci-lint run --new-from-rev=origin/trunk ./...gh skill install android/skills r8-analyzer --dir <temp-dir>