Exposed relative feature importance by xdavio · Pull Request #6 · civisanalytics/python-glmnet · GitHub
Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Exposed relative feature importance #6

Merged
xdavio merged 6 commits into
civisanalytics:masterfrom
xdavio:features
Sep 15, 2016
Merged

Exposed relative feature importance #6
xdavio merged 6 commits into
civisanalytics:masterfrom
xdavio:features

Conversation

@xdavio

@xdavio xdavio commented Sep 13, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@xdavio

xdavio commented Sep 13, 2016

Copy link
Copy Markdown
Contributor Author

Comment thread glmnet/linear.py
self.verbose = verbose

def fit(self, X, y, sample_weight=None):
def fit(self, X, y, sample_weight=None, relative_penalties=None):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring below will need an entry for relative_penalties, looks like it's missing one for sample_weight too.

@xdavio

xdavio commented Sep 13, 2016

Copy link
Copy Markdown
Contributor Author

@wlattner wlattner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@xdavio xdavio merged commit dac5af2 into civisanalytics:master Sep 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants