{{ message }}
style: apply biome 2.x safe autofixes across the repo#518
Merged
Conversation
|
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderdan
force-pushed
the
chore/biome-format-cleanup
branch
from
da3be8a to
b793578
Compare
Now that biome.json parses under biome 2.x (#517), run `biome check --write` to clear the backlog of auto-fixable findings that were invisible while the config was unparseable. Safe fixes only — formatting reflow plus safe lint fixes (import sorting, etc.). The 351 unsafe fixes and the remaining non-autofixable lint findings are intentionally left for manual follow-up. Mechanical change; no behavior change. Verified: CLI suite (312 tests) and script self-tests (20) pass; reformatted packages with credential-free unit tests pass; the remaining monorepo test failures are pre-existing DB-integration tests (Missing DATABASE_URL) that fail identically on the base branch.
… pass Formats 5 source files that landed on main after this branch was first written (wasm-inline, cli native/doctor, wasm e2e test). Pure biome 2.x safe-fix output, except: biome mangles the inline comment on WasmClientConfig's intersection type into nonsense prose, so that note is relocated into the object body where biome leaves it stable (idempotent).
coderdan
force-pushed
the
chore/biome-format-cleanup
branch
from
b793578 to
8a365b2
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #517 (the config migration). Stacked on
chore/biome-2-config— review/merge that first; this retargets tomainonce it lands.What
With
biome.jsonparsing again under biome 2.x, ranbiome check --writeto clear the backlog of auto-fixable findings that were invisible while the config was broken. Safe fixes only —--unsafewas not used.it.each([...])reflow) with identical behavior.import 'x') were reordered (verified) — so no import-ordering side-effect risk.Blast radius
296 files (278
.ts, 14.json, 4.mjs):Verification
This is mechanical, but verified as far as the local env allows (no DB/credentials here):
pnpm test→ 312 passed.mjs) — self-tests 20 passed, pluslint:runnersandlint:workflow-cache(the CI lint scripts) passMissing env.DATABASE_URL,searchable-json-pg) that fail identically on the base branch; not affected by this changeOut of scope (follow-up)
After this, biome still reports 8 errors + 394 warnings + 81 infos that are not safe-autofixable — these need manual review (and/or a reviewed
biome check --write --unsafepass). Left for a separate change so this PR stays purely mechanical.Notes
code:fix.packages/cli/src/bin/stash.ts(that PR rewrites the file). Whichever merges second should rebase; the cleanup here is formatting-only.