{{ message }}
Repository navigation
hive: Remove redundant netip.Prefix config decode hook - #49090
Merged
Merged
Conversation
`cilium/hive` v1.0.6 includes cilium/hive#79, which adds `mapstructure.TextUnmarshallerHookFunc()` to the default config decode hooks. Config fields of any type implementing `encoding.TextUnmarshaler`, including `netip.Prefix`, now decode out of the box. The default hooks run before the extra hooks passed via `Options.DecodeHooks`, so the `netip.Prefix` hook in `pkg/hive` never sees a string input anymore and is dead code. Remove it, along with the associated TODO, which waited on go-viper/mapstructure#85 and is now obsolete. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
maintainer-s-little-helper
Bot
added
the
dont-merge/needs-release-note-label
HadrienPatte
added
kind/cleanup
maintainer-s-little-helper
Bot
removed
the
dont-merge/needs-release-note-label
This comment has been minimized.
This comment has been minimized.
tklauser
approved these changes
Sep 29, 2026
joestringer
enabled auto-merge
September 30, 2026 04:23
derailed
approved these changes
Sep 30, 2026
maintainer-s-little-helper
Bot
added
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cilium/hivev1.0.6 includes cilium/hive#79, which addsmapstructure.TextUnmarshallerHookFunc()to the default config decode hooks. Config fields of any type implementingencoding.TextUnmarshaler, includingnetip.Prefix, now decode out of the box.The default hooks run before the extra hooks passed via
Options.DecodeHooks, so thenetip.Prefixhook inpkg/hivenever sees a string input anymore and is dead code. Remove it, along with the associated TODO, which waited on go-viper/mapstructure#85 and is now obsolete.