{{ message }}
fix(rust): format output.rs chain for stable rustfmt - #3238
Merged
Conversation
The workspace-wide `cargo clippy --all-targets` added by the Rust CI coverage (cli-rust-ci.yml) surfaces `clippy::items_after_test_module` in ch-monitor-cli/src/output.rs: the success/warn/info fns were defined after `mod tests`. Move them before the test module so the new coverage job passes on main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: duyetbot <bot@duyet.net>
Follow-up to #3234: stable rustfmt (1.98 in CI) reformats the .min().max() chain in braile_sparkline across lines; the single-line form fails cargo fmt --all -- --check on main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: duyetbot <bot@duyet.net>
duyet
enabled auto-merge (squash)
August 23, 2026 04:51
Contributor
duyet
added a commit
that referenced
this pull request
Aug 23, 2026
ci-rust-ci.yml: squash merge of #3238 collapsed to base (single-line) despite the PR HEAD containing the multi-line split. Re-apply the correct formatting so cargo fmt --all -- --check passes on stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up: stable rustfmt (1.98) splits the single-line .min().max() chain in ch-monitor-cli/src/output.rs into multiple lines; the previous form fails cargo fmt --all -- --check on CI runners. Closes #3223.