{{ message }}
fix(insights): break baseline import cycle + clear round-3 format drift - #2220
Merged
Conversation
…cycle Plan 48 introduced a circular dependency (baseline-store imports the Baseline type from statistical-baseline, which imports the store's getBaseline/upsertBaseline for refit) — a no-circular depcruise violation that landed because depcruise is non-blocking for auto-merge. Extract the shared types (Baseline, BaselineConfidence, AnomalyScore) into a leaf baseline-types module; re-export from statistical-baseline for existing consumers. No behavior change. Co-Authored-By: duyetbot <bot@duyet.net>
Format drift from plans 35/48/51/62 (agents verified with `bun run lint` but not `bun run check`, which also formats) — was failing the pre-push `check` gate. No behavior change. Co-Authored-By: duyetbot <bot@duyet.net>
github-actions
Bot
added
the
app: dashboard
duyet
enabled auto-merge (squash)
July 3, 2026 08:32
Contributor
☁️ Cloudflare Preview Deployment
|
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two repo-health fixes to get
main's dependency-boundary + format gates green:baseline-store.ts↔statistical-baseline.ts(no-circulardepcruise error). Extracted the shared types into a leafbaseline-types.ts; re-exported fromstatistical-baselineso consumers are unchanged. No behavior change.bun run lintbut notbun run check, which also formats) — was failing the pre-pushcheckgate. Pure formatting, no behavior change.Verification
depcruise → baseline cycle gone ·
bunx biome check .→ clean (1933 files) · dashboardtype-check✅ ·bun test src/lib/insights321 pass ✅ ·bun run lint✅ · pre-push hook (check + test:unit + test:packages) passed.Co-Authored-By: duyetbot bot@duyet.net