No longer version private packages by default by Andarist · Pull Request #2186 · changesets/changesets · GitHub
Skip to content

No longer version private packages by default - #2186

Merged
bluwy merged 4 commits into
mainfrom
private-pkgs-default
Jul 27, 2026
Merged

bluwy merged 4 commits into
mainfrom
private-pkgs-default

Conversation

@Andarist

Copy link
Copy Markdown
Member

No description provided.

@Andarist
Andarist requested a review from beeequeue July 25, 2026 21:09
@changeset-bot

changeset-bot Bot commented Jul 25, 2026 •

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.57%. Comparing base (3816f4f) to head (d4909c3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2186      +/-   ##
==========================================
+ Coverage   84.53%   84.57%   +0.03%     
==========================================
  Files          80       80              
  Lines        3124     3125       +1     
  Branches      879      878       -1     
==========================================
+ Hits         2641     2643       +2     
+ Misses        428      427       -1     
  Partials       55       55              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Andarist
Andarist requested a review from bluwy July 26, 2026 21:01
@Andarist
Andarist marked this pull request as ready for review July 26, 2026 21:01

@bluwy bluwy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small code nit. Thanks for handling this on behalf of my laziness 😄

Also, maybe we should also consider supporting privatePackages: true

Comment thread packages/config/src/config.ts
Comment thread docs/versioning-apps.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I think it's ok to not update the docs/ too since we're moving to the site (I've added a warning at the top of these files in the docs branch). But we'll need to update these for the site later for sure.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should just merge the next-docs branch at this point, to make it easier to edit?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't much big changes needed for docs now, so yeah I think we can consider merging now

Comment thread docs/config-file-options.md Outdated
@Andarist
Andarist enabled auto-merge July 27, 2026 09:43
@Andarist
Andarist added this pull request to the merge queue Jul 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 27, 2026
@bluwy
bluwy added this pull request to the merge queue Jul 27, 2026
Merged via the queue into main with commit 3910adf Jul 27, 2026
15 checks passed
@bluwy
bluwy deleted the private-pkgs-default branch July 27, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants