{{ message }}
Repository navigation
Fix pnpm 11 publish errors handling - #2132
Merged
Andarist merged 5 commits intoJul 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2132 +/- ##
==========================================
+ Coverage 87.67% 88.24% +0.57%
==========================================
Files 72 72
Lines 2596 2604 +8
Branches 691 698 +7
==========================================
+ Hits 2276 2298 +22
+ Misses 296 283 -13
+ Partials 24 23 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Andarist
reviewed
Jun 29, 2026
Comment on lines
+402
to
+407
Member
There was a problem hiding this comment.
I'm not a fan of this. We should use targeted logic. We should probably hoist the formatPublishError call and use the normalized error throughout the caller's logic
Andarist
changed the title
Andarist
enabled auto-merge
July 2, 2026 11:06
Andarist
approved these changes
Jul 2, 2026
Andarist
approved these changes
Jul 2, 2026
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error.summary.summary,detail,message, and raw stdout/stderr for the already-published message.Fixes #2099
Test plan
pnpm install --frozen-lockfilepnpm vitest run packages/cli/src/commands/publish/__tests__/index.test.ts packages/cli/src/commands/publish/__tests__/publishPackages.test.ts packages/cli/src/commands/publish/__tests__/npm-utils.test.tspnpm lint -- packages/cli/src/commands/publish/npm-utils.ts packages/cli/src/commands/publish/__tests__/npm-utils.test.tspnpm types:checkpnpm formatgit diff --check