replace curly braces with square braces by oadam · Pull Request #254 · census-instrumentation/opencensus-php · GitHub
Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

replace curly braces with square braces#254

Closed
oadam wants to merge 1 commit into
census-instrumentation:masterfrom
oadam:patch-1
Closed

replace curly braces with square braces#254
oadam wants to merge 1 commit into
census-instrumentation:masterfrom
oadam:patch-1

Conversation

@oadam

@oadam oadam commented Feb 28, 2020

Copy link
Copy Markdown

To avoid notice "Array and string offset access syntax with curly braces is deprecated" in php 7.4

To avoid notice "Array and string offset access syntax with curly braces is deprecated"
@googlebot

Copy link
Copy Markdown

@oadam

oadam commented Feb 28, 2020

Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@oadam

oadam commented Feb 28, 2020

Copy link
Copy Markdown
Author

The test failed due to a random 404 in a build step unrelated to my change.
Someone with circleci write access needs to relaunch it.

@DiederikvandenB

Copy link
Copy Markdown

Any update on this?

@rlerdorf

Copy link
Copy Markdown

Would be nice to get this merged.

@kees-tce

Copy link
Copy Markdown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants