{{ message }}
This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Add OneLineEchoExporter#177
Merged
chingor13 merged 2 commits intoApr 23, 2018
Merged
Conversation
chingor13
suggested changes
Apr 20, 2018
chingor13
left a comment
chingor13
left a comment
Member
There was a problem hiding this comment.
Thanks for this! LGTM with a few nit comments.
Also, you'll need to sign the CLA agreement or we won't be able to take it.
| | Class | Description | Dependency | | ||
| | ----- | ----------- | ---------- | | ||
| | [EchoExporter][echo-exporter] | Output the collected spans to stdout | | | ||
| | [OneLineEchoExporter][one-line-echo-exporter] | Output the collected spans to stdout with one-line | | |
Member
There was a problem hiding this comment.
Can we move this after the NullExporter to preserve alphabetical order?
| @@ -0,0 +1,42 @@ | |||
| <?php | |||
| /** | |||
| * Copyright 2017 OpenCensus Authors | |||
Member
There was a problem hiding this comment.
This should be 2018 for each of the files.
| $this->assertTrue($exporter->export([$span->spanData()])); | ||
| $output = ob_get_contents(); | ||
| ob_end_clean(); | ||
| $this->assertEquals('[ 10000.00 ms] span' . PHP_EOL, $output); |
Member
There was a problem hiding this comment.
Looks like this is occasionally failing tests if the microtime changes between startTime and endTime lines. If you capture the time in a local variable and then add 10 to that number, this should consistently pass.
| @@ -0,0 +1,44 @@ | |||
| <?php | |||
| /** | |||
| * Copyright 2017 OpenCensus Authors | |||
Contributor
Author
|
@googlebot |
|
CLAs look good, thanks! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref googleapis/google-cloud-php#1009 (comment)
Add simple one-line exporter like this: