SpanData now implements stackTraceHashId() by chingor13 · Pull Request #154 · census-instrumentation/opencensus-php · GitHub
Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

SpanData now implements stackTraceHashId()#154

Merged
chingor13 merged 3 commits into
masterfrom
stack-trace-hash-id
Apr 2, 2018
Merged

SpanData now implements stackTraceHashId()#154
chingor13 merged 3 commits into
masterfrom
stack-trace-hash-id

Conversation

@chingor13

@chingor13 chingor13 commented Mar 29, 2018

Copy link
Copy Markdown
Member

Fixes #121

Returning the stackTraceHashId as a 16-digit hex string as PHP's built-in integer is signed.

@chingor13 chingor13 requested a review from tmatsuo April 2, 2018 18:11
@chingor13 chingor13 merged commit 8d8ae0e into master Apr 2, 2018
@chingor13 chingor13 deleted the stack-trace-hash-id branch April 2, 2018 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants