SpanKind support in opencensus-java · Issue #1054 · census-instrumentation/opencensus-java · GitHub
Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

SpanKind support in opencensus-java #1054

Closed

Description

@HailongWen

census-instrumentation/opencensus-proto#51 added SpanKind. We should add the initial support.

Another thread is discussing whether to add consumer/producer in the type census-instrumentation/opencensus-specs#54. This could be merged after the decision is made.

Activity

  1. bogdandrutu commented on Mar 15, 2018

    @bogdandrutu
    Contributor

    I think we can add the SpanKind right now and extend later if needed, I would suggest that we update the docs related to HTTP/gRPC span names to not include "Sent." and "Recv." which we will be able to determine from the SpanKind.

    Also we need to update the https://github.com/census-instrumentation/opencensus-java/blob/master/impl_core/src/main/java/io/opencensus/implcore/trace/export/InProcessSampledSpanStoreImpl.java to map not only by name but also by SpanKind.

  2. self-assigned this
    on May 31, 2018
  3. bogdandrutu commented on Jun 1, 2018

    @bogdandrutu
    Contributor

    This is also related #1226

  4. voidzcy commented on Mar 25, 2020

    @voidzcy

    gRPC is trying to migrate to use SpanKind (see grpc/grpc-java#6732), but since Span name is changed, this seems to be a "flip the switch" change for traffic monitoring pipelines. How should we migrate this in gRPC for OSS without breaking open-source users' traffic monitoring pipelines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions