Fix error message for missing attribute by copybara-service[bot] · Pull Request #962 · cel-expr/cel-java · GitHub
Skip to content

Fix error message for missing attribute #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Feb 20, 2026
Merged

Fix error message for missing attribute #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions common/src/main/java/dev/cel/common/exceptions/CelAttributeNotFoundException.java
View file
Open in desktop
30 changes: 24 additions & 6 deletions runtime/src/main/java/dev/cel/runtime/planner/MissingAttribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,26 +22,44 @@
final class MissingAttribute implements Attribute {

private final ImmutableSet<String> missingAttributes;
private final Kind kind;

@Override
public Object resolve(GlobalResolver ctx, ExecutionFrame frame) {
throw CelAttributeNotFoundException.forFieldResolution(missingAttributes);
switch (kind) {
case ATTRIBUTE_NOT_FOUND:
throw CelAttributeNotFoundException.forMissingAttributes(missingAttributes);
case FIELD_NOT_FOUND:
throw CelAttributeNotFoundException.forFieldResolution(missingAttributes);
}

throw new IllegalArgumentException("Unexpected kind: " + kind);
}

@Override
public Attribute addQualifier(Qualifier qualifier) {
throw new UnsupportedOperationException("Unsupported operation");
}

static MissingAttribute newMissingAttribute(String... attributeNames) {
return newMissingAttribute(ImmutableSet.copyOf(attributeNames));
static MissingAttribute newMissingAttribute(ImmutableSet<String> attributeNames) {
return new MissingAttribute(attributeNames, Kind.ATTRIBUTE_NOT_FOUND);
}

static MissingAttribute newMissingAttribute(ImmutableSet<String> attributeNames) {
return new MissingAttribute(attributeNames);
static MissingAttribute newMissingField(String... attributeNames) {
return newMissingField(ImmutableSet.copyOf(attributeNames));
}

private MissingAttribute(ImmutableSet<String> missingAttributes) {
static MissingAttribute newMissingField(ImmutableSet<String> attributeNames) {
return new MissingAttribute(attributeNames, Kind.FIELD_NOT_FOUND);
}

private MissingAttribute(ImmutableSet<String> missingAttributes, Kind kind) {
this.missingAttributes = missingAttributes;
this.kind = kind;
}

private enum Kind {
ATTRIBUTE_NOT_FOUND,
FIELD_NOT_FOUND
}
}
4 changes: 2 additions & 2 deletions runtime/src/main/java/dev/cel/runtime/planner/PresenceTestQualifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

package dev.cel.runtime.planner;

import static dev.cel.runtime.planner.MissingAttribute.newMissingAttribute;
import static dev.cel.runtime.planner.MissingAttribute.newMissingField;

import dev.cel.common.values.SelectableValue;
import java.util.Map;
Expand All @@ -40,7 +40,7 @@ public Object qualify(Object obj) {
return map.containsKey(value);
}

return newMissingAttribute(value.toString());
return newMissingField(value.toString());
}

static PresenceTestQualifier create(Object value) {
Expand Down
18 changes: 13 additions & 5 deletions runtime/src/test/java/dev/cel/runtime/planner/ProgramPlannerTest.java
View file
Open in desktop
Loading