Remove deprecated setContainer(string) builder method by copybara-service[bot] · Pull Request #769 · cel-expr/cel-java · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions bundle/src/main/java/dev/cel/bundle/CelBuilder.java
6 changes: 0 additions & 6 deletions bundle/src/main/java/dev/cel/bundle/CelImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,6 @@ public CelBuilder addMacros(Iterable<CelMacro> macros) {
return this;
}

@Override
public CelBuilder setContainer(String container) {
compilerBuilder.setContainer(container);
return this;
}

@Override
public CelContainer container() {
return compilerBuilder.container();
Expand Down
7 changes: 0 additions & 7 deletions checker/src/main/java/dev/cel/checker/CelCheckerBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,6 @@ public interface CelCheckerBuilder {
@CanIgnoreReturnValue
CelCheckerBuilder setOptions(CelOptions options);

/**
* @deprecated Use {@link #setContainer(CelContainer)} instead.
*/
@CanIgnoreReturnValue
@Deprecated
CelCheckerBuilder setContainer(String container);

/**
* Set the {@link CelContainer} to use as the namespace for resolving CEL expression variables and
* functions.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,6 @@ public CelCheckerBuilder setOptions(CelOptions celOptions) {
return this;
}

@Override
public CelCheckerBuilder setContainer(String container) {
checkNotNull(container);
return setContainer(CelContainer.ofName(container));
}

@Override
public CelCheckerBuilder setContainer(CelContainer container) {
checkNotNull(container);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,6 @@ public interface CelCompilerBuilder {
@CanIgnoreReturnValue
CelCompilerBuilder setOptions(CelOptions options);

/**
* @deprecated Use {@link #setContainer(CelContainer)} instead.
*/
@CanIgnoreReturnValue
@Deprecated
CelCompilerBuilder setContainer(String container);

/**
* Set the {@link CelContainer} to use as the namespace for resolving CEL expression variables and
* functions.
Expand Down
6 changes: 0 additions & 6 deletions compiler/src/main/java/dev/cel/compiler/CelCompilerImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,6 @@ public CelCompilerBuilder addMacros(Iterable<CelMacro> macros) {
return this;
}

@Override
public CelCompilerBuilder setContainer(String container) {
checkerBuilder.setContainer(container);
return this;
}

@Override
public CelCompilerBuilder setContainer(CelContainer container) {
checkerBuilder.setContainer(container);
Expand Down