Open source Java conformance tests by copybara-service[bot] · Pull Request #413 · cel-expr/cel-java · GitHub
Skip to content

Open source Java conformance tests #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 12, 2024
Merged

Open source Java conformance tests #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/workflow.yml
View file
Open in desktop
6 changes: 3 additions & 3 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,10 @@ http_archive(
# cel-spec api/expr canonical protos
http_archive(
name = "cel_spec",
sha256 = "3ee09eb69dbe77722e9dee23dc48dc2cd9f765869fcf5ffb1226587c81791a0b",
strip_prefix = "cel-spec-0.15.0",
sha256 = "65a153c1c4d73a135c364a4955e6aabd1093f0ed291774d3637f350504505085",
strip_prefix = "cel-spec-0789389e13a0626ec3521e4f109acce360565ce6",
urls = [
"https://github.com/google/cel-spec/archive/refs/tags/v0.15.0.tar.gz",
"https://github.com/google/cel-spec/archive/0789389e13a0626ec3521e4f109acce360565ce6.tar.gz",
],
)

Expand Down
2 changes: 1 addition & 1 deletion checker/src/main/java/dev/cel/checker/CelProtoExprVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import dev.cel.common.CelProtoAbstractSyntaxTree;

/**
* CEL expression visitor implementation based on the {@link com.google.api.expr.Expr} proto.
* CEL expression visitor implementation based on the {@link dev.cel.expr.Expr} proto.
*
* <p>Note: Prefer using {@link dev.cel.common.ast.CelExprVisitor} if protobuf support is not
* needed.
Expand Down
12 changes: 6 additions & 6 deletions common/src/main/java/dev/cel/common/CelProtoAbstractSyntaxTree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,12 @@ private CelProtoAbstractSyntaxTree(CelAbstractSyntaxTree ast) {
this.checkedExpr = checkedExprBuilder.build();
}

/** Construct an abstract syntax tree from a {@link com.google.api.expr.CheckedExpr}. */
/** Construct an abstract syntax tree from a {@link dev.cel.expr.CheckedExpr}. */
public static CelProtoAbstractSyntaxTree fromCheckedExpr(CheckedExpr checkedExpr) {
return new CelProtoAbstractSyntaxTree(checkedExpr);
}

/** Construct an abstract syntax tree from a {@link com.google.api.expr.ParsedExpr}. */
/** Construct an abstract syntax tree from a {@link dev.cel.expr.ParsedExpr}. */
public static CelProtoAbstractSyntaxTree fromParsedExpr(ParsedExpr parsedExpr) {
return new CelProtoAbstractSyntaxTree(
CheckedExpr.newBuilder()
Expand Down Expand Up @@ -137,7 +137,7 @@ public CelAbstractSyntaxTree getAst() {
}

/**
* Returns the underlying {@link com.google.api.expr.Expr} representation of the abstract syntax
* Returns the underlying {@link dev.cel.expr.Expr} representation of the abstract syntax
* tree.
*/
@CheckReturnValue
Expand All @@ -146,7 +146,7 @@ public Expr getExpr() {
}

/**
* Returns the underlying {@link com.google.api.expr.CheckedExpr} representation of the abstract
* Returns the underlying {@link dev.cel.expr.CheckedExpr} representation of the abstract
* syntax tree. Throws {@link java.lang.IllegalStateException} if {@link
* CelAbstractSyntaxTree#isChecked} is false.
*/
Expand All @@ -159,7 +159,7 @@ public CheckedExpr toCheckedExpr() {
}

/**
* Returns the underlying {@link com.google.api.expr.SourceInfo} representation of the abstract
* Returns the underlying {@link dev.cel.expr.SourceInfo} representation of the abstract
* syntax tree.
*/
@CheckReturnValue
Expand All @@ -168,7 +168,7 @@ public SourceInfo getSourceInfo() {
}

/**
* Returns the underlying {@link com.google.api.expr.ParsedExpr} representation of the abstract
* Returns the underlying {@link dev.cel.expr.ParsedExpr} representation of the abstract
* syntax tree.
*/
@CheckReturnValue
Expand Down
2 changes: 1 addition & 1 deletion common/src/main/java/dev/cel/common/internal/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import java.util.PrimitiveIterator;

/**
* Internal utility class for working with {@link com.google.api.expr.Constant}.
* Internal utility class for working with {@link dev.cel.expr.Constant}.
*
* <p>CEL Library Internals. Do Not Use.
*/
Expand Down
4 changes: 2 additions & 2 deletions common/src/main/java/dev/cel/common/internal/DefaultInstanceMessageFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
* <p>CEL Library Internals. Do Not Use.
*/
@Internal
final class DefaultInstanceMessageFactory {
public final class DefaultInstanceMessageFactory {

// Controls how many times we should recursively inspect a nested message for building fully
// qualified java class name before aborting.
Expand Down Expand Up @@ -87,7 +87,7 @@ public Optional<Message> getPrototype(Descriptor descriptor) {
* Retrieves the full Java class name from the given descriptor
*
* @return fully qualified class name.
* <p>Example 1: com.google.api.expr.Value
* <p>Example 1: dev.cel.expr.Value
* <p>Example 2: com.google.rpc.context.AttributeContext$Resource (Nested classes)
* <p>Example 3: com.google.api.expr.cel.internal.testdata$SingleFileProto$SingleFile$Path
* (Nested class with java multiple files disabled)
Expand Down
152 changes: 152 additions & 0 deletions conformance/src/test/java/dev/cel/conformance/BUILD.bazel
View file
Open in desktop
Loading