test: configure in-source testing#97
Conversation
commit: |
ryoppippi
force-pushed
the
vitest-in-source-testing
branch
from
36b262f to
b566cc7
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request fundamentally changes how tests are structured and executed within the project by adopting an in-source testing approach with Vitest. This involves embedding test logic directly within the application's source files, significantly expanding test coverage for critical components like cost calculation, data loading, debugging utilities, pricing fetching, and session block identification. The accompanying build system updates ensure that these test-specific code blocks are automatically excluded from the final production bundles, maintaining code efficiency while enhancing development-time testability.
Highlights
- In-source Testing Adoption: The project is transitioning to an in-source testing strategy using Vitest, embedding test logic directly within source files. This allows tests to live alongside the code they validate.
- Extensive Test Coverage: Significant new test suites have been added across multiple core modules, including
calculate-cost,data-loader,debug,pricing-fetcher,session-blocks, andutils, to validate existing functionality and ensure robustness. - Build System Integration for Test Stripping: The build configuration (
tsdown.config.ts) has been updated to automatically remove these in-source test blocks from production builds, ensuring that test code does not ship with the final application bundle. - Module Consolidation and Refactoring: The
ResponsiveTableutility has been moved from its dedicated file (utils.table.ts) intoutils.internal.ts, streamlining the project's utility module structure and simplifying imports across various command files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces in-source testing with Vitest and a new ResponsiveTable class. The addition of tests is a positive step. However, several types in src/session-blocks.internal.ts need to be exported, and the ResponsiveTable class could benefit from improved maintainability and dedicated unit tests.
| * Aggregated token counts for different token types | ||
| */ | ||
| export type TokenCounts = { | ||
| type TokenCounts = { |
There was a problem hiding this comment.
The TokenCounts type is used in the exported SessionBlock type but is not exported itself. This can cause issues for TypeScript consumers of this library when trying to use SessionBlock or during declaration file generation.
| type TokenCounts = { | |
| export type TokenCounts = { |
| * Represents usage burn rate calculations | ||
| */ | ||
| export type BurnRate = { | ||
| type BurnRate = { |
There was a problem hiding this comment.
The BurnRate type is the return type of the exported function calculateBurnRate but is not exported itself. Exporting it ensures type safety and proper declaration file generation.
| type BurnRate = { | |
| export type BurnRate = { |
| * Represents projected usage for remaining time in a session block | ||
| */ | ||
| export type ProjectedUsage = { | ||
| type ProjectedUsage = { |
There was a problem hiding this comment.
The ProjectedUsage type is the return type of the exported function projectBlockUsage but is not exported itself. Exporting it is necessary for the module's public API to be correctly typed.
| type ProjectedUsage = { | |
| export type ProjectedUsage = { |
There was a problem hiding this comment.
The ResponsiveTable class uses hardcoded indices to determine column widths. This makes the class tightly coupled to the specific column order. Consider using column type hints in TableOptions instead.
test: configure in-source testing
1 participant
use vitest in-source testing
Summary by CodeRabbit
New Features
Refactor
Bug Fixes
Tests
Chores