apps/opencode/src/data-loader.ts (2)

343-358: Consider making synchronous functions non-async.

Both loadOpenCodeSessions() and loadOpenCodeMessages() are marked async but contain no await expressions - they only call the synchronous queryOpenCodeDatabase(). This works but adds unnecessary Promise wrapping overhead.

♻️ Optional simplification

If backward compatibility allows, these could return synchronously:

-export async function loadOpenCodeSessions(): Promise<Map<string, LoadedSessionMetadata>> {
+export function loadOpenCodeSessions(): Map<string, LoadedSessionMetadata> {

However, keeping them async maintains API consistency if callers expect Promises.

Also applies to: 364-383

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/opencode/src/data-loader.ts` around lines 343 - 358, Remove unnecessary
async/Promise wrapping for functions that don't use await: change
loadOpenCodeSessions (and likewise loadOpenCodeMessages) to be synchronous by
removing the async keyword and updating their return types from
Promise<Map<string, LoadedSessionMetadata>> (or Promise<...>) to Map<string,
LoadedSessionMetadata> (and the corresponding return for messages). Keep the
existing logic that calls the synchronous queryOpenCodeDatabase() and ensure any
callers are updated to handle the synchronous return (or left as-is if they
already await; adjust callers to stop awaiting if you make this change).

---

16-17: Move test-only import inside vitest block.

fs-fixture is only used within the if (import.meta.vitest != null) block (lines 495, 640). Importing it at the module level includes it in the production bundle unnecessarily.

♻️ Proposed fix

Move the import inside the test block:

-import { createFixture } from 'fs-fixture';
 import { isDirectorySync } from 'path-type';

Then inside the vitest block:

 if (import.meta.vitest != null) {
 	const { afterEach, describe, expect, it, vi } = import.meta.vitest;
+	const { createFixture } = await import('fs-fixture');

Note: Per coding guidelines, dynamic await import() should be avoided. Instead, consider a conditional require pattern or accept the import for tree-shaking at build time if tsdown handles dead-code elimination for the vitest guard.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/opencode/src/data-loader.ts` around lines 16 - 17, The top-level import
"import { createFixture } from 'fs-fixture';" is test-only and should be moved
inside the vitest guard to avoid including it in production bundles: remove the
module-level import and instead require it inside the existing "if
(import.meta.vitest != null) { ... }" block where createFixture is used (the
blocks referencing createFixture), e.g. const { createFixture } =
require('fs-fixture'); so only test code loads fs-fixture; leave isDirectorySync
at module scope if still needed by runtime code. Ensure all references to
createFixture inside the vitest block use the locally required binding.