Remove project column from session command#57
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the output of the session command by removing the project-specific column and data. The change affects both the standard table output and the JSON output, making the command's reporting more focused on session details.
Highlights
- Command Output: Removed the 'Project' column from the table output generated by the
sessioncommand. - JSON Output: Removed the
projectPathfield from the JSON output generated by thesessioncommand. - Code Cleanup: Removed associated logic for handling the 'Project' column, including table alignment, width calculation, and breakdown row offset adjustments.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
commit: |
• Eliminate projectPath from JSON output format • Remove Project column from table headers and alignment • Update table row generation to exclude project display • Adjust separator and totals rows for new column count • Modify breakdown row positioning for updated column layout This simplifies the session view by focusing on session-specific data rather than project organization, making the output cleaner and more focused on conversation sessions.
ryoppippi
force-pushed
the
feature/remove-project
branch
from
fec9f1d to
dfdf17f
Compare
Remove project column from session command
There was a problem hiding this comment.
Code Review
This pull request removes the project column from the session command output. The changes involve modifications to the JSON output, table headers, column alignments, and data processing loops. Ensure the test plan is fully executed to verify the changes.
| const jsonOutput = { | ||
| sessions: sessionData.map(data => ({ | ||
| projectPath: data.projectPath, | ||
| sessionId: data.sessionId, |
There was a problem hiding this comment.
Removing projectPath streamlines the JSON output as intended.
| const table = new Table({ | ||
| head: [ | ||
| 'Project', | ||
| 'Session', |
There was a problem hiding this comment.
Removing 'Project' from the table header simplifies the session-focused reporting.
| 'left', | ||
| 'left', | ||
| 'right', |
There was a problem hiding this comment.
Removing the 'left' alignment for the 'Project' column adjusts the table formatting.
| }); | ||
|
|
||
| let maxProjectLength = 0; | ||
| let maxSessionLength = 0; |
There was a problem hiding this comment.
The maxProjectLength variable is no longer needed since the project column has been removed.
| maxSessionLength = Math.max(maxSessionLength, sessionDisplay.length); | ||
|
|
||
| // Main row | ||
| table.push([ |
There was a problem hiding this comment.
Removing projectDisplay from the table push aligns with the removal of the project column.
| // Session has 1 extra column before data and 1 trailing column | ||
| pushBreakdownRows(table, data.modelBreakdowns, 1, 1); |
There was a problem hiding this comment.
Adjusting extraColumns in pushBreakdownRows to 1 correctly accounts for the removed 'Project' column.
| // Session has 1 extra column before data and 1 trailing column | |
| pushBreakdownRows(table, data.modelBreakdowns, 1, 1); | |
| pushBreakdownRows(table, data.modelBreakdowns, 1, 1); |
| // Add separator | ||
| table.push([ | ||
| '─'.repeat(maxProjectLength), // For Project | ||
| '─'.repeat(maxSessionLength), // For Session |
There was a problem hiding this comment.
Removing the line that repeats the character for the project length.
There was a problem hiding this comment.
Removing the empty string for the project column in the totals row.
Remove project column from session command
1 participant
Summary
• Remove project column from session command output to streamline session-focused reporting
Test plan
Summary by CodeRabbit