iframe-proxy

zerone0x · 2026-05-18T02:45:53Z

Summary by cubic

Deduplicates repeated session usage rows in loadSessionUsageById to prevent double counting and inflated totals. Fixes #994.

Bug Fixes
- Detects duplicate entries by a stable hash and keeps the better one (more tokens, or with speed).
- Replaces existing entries in-place and adjusts totalCost so sums stay accurate.
- Adds a test that verifies dedupe and correct cost/entry counts.

^{Written for commit 1eb6580. Summary will update on new commits. Review in cubic}

Summary by CodeRabbit

Bug Fixes
- Resolved duplicate entries in session usage records to ensure accurate usage tracking and cost calculations.
Tests
- Added test coverage for session-level deduplication behavior.

Fixes ccusage#994 Co-Authored-By: Claude <noreply@anthropic.com>

coderabbitai · 2026-05-18T02:46:03Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 61771b8e-e42f-4a33-b1cb-d0a45f747cc9

📥 Commits

Reviewing files that changed from the base of the PR and between a291981 and 1eb6580.

📒 Files selected for processing (1)

apps/ccusage/src/adapter/claude/data-loader.ts

📝 Walkthrough

Walkthrough

The PR adds session-level deduplication to loadSessionUsageById in the data loader. During JSONL parsing, duplicate usage rows identified by createUniqueHash are collapsed into single entries, with conditional replacement based on shouldReplaceEntryMetadata and totalCost updated accordingly. A test case verifies the deduplication behavior.

Changes

Session-level deduplication

Layer / File(s)	Summary
Deduplication logic and initialization `apps/ccusage/src/adapter/claude/data-loader.ts`	`loadSessionUsageById` initializes a `processedEntries` dedupe index and deduplicates rows during JSONL parsing by computing `uniqueHash`, detecting duplicates, conditionally replacing previous entries with `shouldReplaceEntryMetadata`, and updating `totalCost` to subtract old costs and add new ones.
Deduplication test verification `apps/ccusage/src/adapter/claude/data-loader.ts`	New test case validates that `loadSessionUsageById` collapses repeated usage rows into expected unique entries and returns the correct `requestId` sequence.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

ryoppippi/ccusage#994: The PR implements session-level deduplication using createUniqueHash and shouldReplaceEntryMetadata with cost correction, directly addressing the missing dedupe behavior reported in this issue.

Possibly related PRs

ryoppippi/ccusage#985: Both PRs modify deduplication in loadSessionUsageById using createUniqueHash, with this PR adding per-session replacement logic while the retrieved PR adjusts the hash fallback key.
ryoppippi/ccusage#58: Both PRs update data-loader deduplication keyed by message.id/requestId; this PR adds session-level replacement and cost correction within the same dedupe pathway.

Suggested reviewers

ryoppippi

Poem

🐰 A session's rows once multiplied,
Now dedup'd with hash as guide.
Cost corrected, duplicates gone,
One true entry carries on! ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/ccusage/src/adapter/claude/data-loader.ts

[baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D
tsconfig.json is not found. we cannot use type-aware rules.

Oops! Something went wrong! :(

ESLint: 9.35.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'eslint-plugin-format' imported from /node_modules/.pnpm/@antfu+eslint-config@4.19.0_@vue+compiler-sfc@3.5.30_eslint@9.35.0_typescript@5.9.2_vit_670a2c5c75d4275eabd7bc195a173ee6/node_modules/@antfu/eslint-config/dist/index.js
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:301:9)
at packageResolve (node:internal/modules/esm/resolve:764:81)
at moduleResolve (node:internal/modules/esm/resolve:855:18)
at defaultResolve (node:internal/modules/esm/resolve:988:11)
at #cachedDefaultResolve (node:internal/modules/esm/loader:697:20)
at #resolveAndMaybeBlockOnLoaderThread (node:internal/modules/esm/loader:714:38)
at ModuleLoader.resolveSync (node:internal/modules/esm/loader:746:52)
at #resolve (node:internal/modules/esm/loader:679:17)
at ModuleLoader.getOrCreateModuleJob (node:internal/modules/esm/loader:599:35)
at node:internal/modules/esm/loader:628:32

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-05-18T02:46:07Z

fix(ccusage): dedupe session usage by id

1eb6580

Fixes ccusage#994 Co-Authored-By: Claude <noreply@anthropic.com>

github-actions Bot closed this May 18, 2026

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(ccusage): dedupe session --id usage rows#1046

fix(ccusage): dedupe session --id usage rows#1046
zerone0x wants to merge 1 commit into
ccusage:mainfrom
zerone0x:claude/fix-issue-994-session-dedupe

zerone0x commented May 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 18, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

zerone0x commented May 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

zerone0x commented May 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 18, 2026 •

edited

Loading