docs(skill): separate the type ramp from the 4px layout grid by avionicharshit-byte · Pull Request #182 · cathrynlavery/diagram-design · GitHub
Skip to content

docs(skill): separate the type ramp from the 4px layout grid - #182

Open
avionicharshit-byte wants to merge 3 commits into
cathrynlavery:mainfrom
avionicharshit-byte:fix/grid-rule-matches-the-design-system
Open

docs(skill): separate the type ramp from the 4px layout grid#182
avionicharshit-byte wants to merge 3 commits into
cathrynlavery:mainfrom
avionicharshit-byte:fix/grid-rule-matches-the-design-system

Conversation

@avionicharshit-byte

@avionicharshit-byte avionicharshit-byte commented Sep 5, 2026

Copy link
Copy Markdown

for #181 .

§7 called "divisible by 4" non-negotiable while §6 specifies font-size="7" , font-size="9" and rx="6" , so §7 is the part that is wrong . this changes §7 , not the assets .

  • the grid rule now covers layout geometry only , so x/y coords , node dimensions , gaps , padding
  • font sizes get a ramp of 7, 8, 9, 10, 11, 12, 14, 16, 24, 32, 40 , what §5 , §6 and the assets already use . 19 stragglers across 12 files , all one offs
  • radius stays 4, 6, 8 and is no longer claimed to be on the grid
  • the quick check was arithmetically wrong , replaced with a remainder check
  • §9's checklist line reworded , it asked for something no diagram built from §6 can confirm

not fixed: 3,727 x/y coords across 130 files are still off grid . that needs a verify-grid.py plus either 130 file edits or a baseline , so it is a separate call .

SKILL.md is 39,993 bytes , under the 40,000 cap . all 47 gates green locally , no manifest versions touched .

closes #181

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown

Comment thread skills/diagram-design/SKILL.md Outdated

@cathrynlavery cathrynlavery left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contradiction is real and all 52 gates pass, but the proposed ramp excludes 470 shipped font-size attributes across 113 files, mostly 8.5px. Also, x/y remains too broad: data-derived, baseline, marker, and optical half-pixel positions cannot be treated as structural layout. Define canonical role/preset sizes with explicit exceptions, scope the 4px rule to structural anchors/dimensions, add docs-consistency regression coverage, preserve the 40KB cap, and link/close #181 when ready.

@avionicharshit-byte

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SKILL.md §7's 4px grid rule contradicts §6, its own table, and 148 of 153 shipped assets

2 participants