{{ message }}
docs(skill): separate the type ramp from the 4px layout grid - #182
Open
avionicharshit-byte wants to merge 3 commits into
Open
docs(skill): separate the type ramp from the 4px layout grid#182avionicharshit-byte wants to merge 3 commits into
avionicharshit-byte wants to merge 3 commits into
Conversation
avionicharshit-byte
marked this pull request as ready for review
September 5, 2026 07:29
cathrynlavery
requested changes
Sep 5, 2026
cathrynlavery
left a comment
Owner
There was a problem hiding this comment.
The contradiction is real and all 52 gates pass, but the proposed ramp excludes 470 shipped font-size attributes across 113 files, mostly 8.5px. Also, x/y remains too broad: data-derived, baseline, marker, and optical half-pixel positions cannot be treated as structural layout. Define canonical role/preset sizes with explicit exceptions, scope the 4px rule to structural anchors/dimensions, add docs-consistency regression coverage, preserve the 40KB cap, and link/close #181 when ready.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

for #181 .
§7 called "divisible by 4" non-negotiable while §6 specifies
font-size="7",font-size="9"andrx="6", so §7 is the part that is wrong . this changes §7 , not the assets .not fixed: 3,727 x/y coords across 130 files are still off grid . that needs a
verify-grid.pyplus either 130 file edits or a baseline , so it is a separate call .SKILL.mdis 39,993 bytes , under the 40,000 cap . all 47 gates green locally , no manifest versions touched .closes #181