{{ message }}
fix: consolidate reviewed repository corrections - #174
Merged
Conversation
`_top_level_mask` blanks quoted spans so that operators inside a label are not mistaken for link syntax. `_edge_operators` then sliced the label out of the `spaced` capture group, but against an all-blank span the non-greedy `.+?` settles on a single masked character, and slicing the original text at that offset returns the closing quote. Every quoted spaced label — `A-- "text" -->B` — became the single character `"`, silently, in all stroke styles and in the multidirectional forms. Read the label from the whole span between the opening and closing operators instead. The compact branch already spans exactly that region, so its behavior is unchanged, and `clean_label` was already stripping padding and surrounding quotes for node labels. Verified against Mermaid 11.17.0's own renderer: all twelve quoted forms now match the text Mermaid draws, and no unquoted form changes.
…ocuments output-spec.md tells authors to extend the family "when labels contain Japanese, Chinese, or Korean text", but only ships Japanese and Korean example stacks, and ALLOWED_FONTS carries no Chinese families at all. A literal `font-family` naming PingFang SC / Noto Sans SC / Microsoft YaHei is therefore rejected as "unsupported font family", while the equivalent Japanese and Korean stacks pass. Mirrors the Japanese (#75) and Korean (#83) fixes: - lint-skin.py: add Simplified (PingFang SC, Noto Sans SC, Microsoft YaHei, Noto Sans Mono CJK SC) and Traditional (PingFang TC, Noto Sans TC, Microsoft JhengHei, Noto Sans Mono CJK TC) families. - output-spec.md: add the SC and TC example stacks, the mono variants, and note why Japanese fonts cannot stand in for Chinese (subset coverage plus Japanese glyph variants for Simplified forms), and why SC and TC are separate stacks. - test-lint-a11y.py: add zh-name-stack, zh-mono-stack, zh-css-stack and zh-tc-stack, matching the existing kr-* cases. Verified the new cases fail without the ALLOWED_FONTS change ("zh-name-stack: expected exit 0, got 1") and pass with it. Co-Authored-By: Claude <noreply@anthropic.com>
The dark line-chart variant shipped with the light palette - paper variant. Tokens flipped to the dark set used by every other -dark example. lint-skin does not compare skin to filename, which is how it slipped through. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The README grid renders 29 screenshots at 252 CSS px and three inline figures at 838 CSS px, but every `<img>` pointed at the full-resolution original: 2400-2800px wide, ~3.7 MB across the page, ~580 MB of decoded bitmap. A burst of 29 oversized requests over one connection loses races. Individual previews stall in flight and paint blank — no broken-image icon, no alt text, a different subset each load. Reloading fixes it, because the second load is a cache hit. Add `scripts/build-readme-thumbs.py`, which writes right-sized WebP copies to `docs/screenshots/thumbs/` (600px q82 for the grid, 1400px q90 for the inline figures), and point README.md at those. Each preview now links to its full-resolution PNG, so nothing is lost — the originals stay exactly where they were. Page previews: 3707 KB -> 268 KB. `--check` re-encodes and diffs without writing, for a CI gate if wanted.
Document Kiro and OpenCode discovery, editable installs across Agent Skills hosts, and the 1024-character Agent Skills description limit. Co-authored-by: kas1987+ <kas1987@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: hsien wei <hsien.w.wei@gmail.com>
Greptile SummaryThis PR consolidates reviewed corrections across diagram imports, visual examples, host documentation, and README delivery.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code defect identified. The updated import parsing, visual-contract checks, font support, README preview pipeline, manifests, and CI wiring are internally consistent and include focused adversarial regression coverage.
|
| Filename | Overview |
|---|---|
| skills/diagram-design/scripts/mermaid_extract.py | Reads quoted edge labels from the original source span while retaining masked operator-boundary detection. |
| scripts/verify-mermaid-import.py | Adds adversarial coverage for quoted labels across solid, dotted, thick, bidirectional, circle, and cross links. |
| scripts/build-readme-thumbs.py | Adds deterministic README preview generation and write-free digest, decode, dimension, wiring, and orphan verification. |
| scripts/test-build-readme-thumbs.py | Exercises source drift, tampering, corruption, incorrect dimensions, orphan files, stale manifests, wiring, and check-mode immutability. |
| .github/workflows/ci.yml | Installs pinned Pillow and runs the README thumbnail tests and freshness check on the Linux Python 3.12 leg. |
| scripts/verify-docs-sync.py | Enforces the Agent Skills description cap and canonical Line dark-skin tokens. |
| scripts/verify-drawio-import.py | Locks the reviewed API Gateway-to-Orders connector to its direct horizontal route. |
| scripts/lint-skin.py | Extends accepted typography to documented Simplified and Traditional Chinese font stacks. |
| README.md | Serves compact WebP previews while retaining direct links to every full-resolution PNG. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Source[Canonical PNG screenshots] --> Generator[README thumbnail generator]
Generator --> WebP[Committed WebP previews]
Generator --> Manifest[Digest and dimension manifest]
WebP --> README[README preview links]
README --> Full[Full-size PNG downloads]
Manifest --> Check[Write-free CI freshness check]
WebP --> Check
Source --> Check
README --> Check
Reviews (1): Last reviewed commit: "docs: add multi-host installation cookbo..." | Re-trigger Greptile
This was referenced Sep 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This maintainer integration bundle applies the small, compatible corrections accepted during the full open-item review. It intentionally leaves major features, drafts, incomplete fixes, and unresolved policy choices in their own review lanes.
Import and visual correctness
Lint and documentation compatibility
SKILL.mdinto loader stubs (docs(cookbook): add operator cookbook and host search paths #163 partial).README delivery
--checkmode.Included items
PR #172 (including hardening commit
3d451e0) merged as8d55bd4during this review and is the base of this branch, so it is not duplicated here.Excluded or deferred items
<title>allowance failsverify-motion.py; settle the verifier fix and ADR 0010 decision separately.DANGEROUS: 34 findings, 6 critical.AUTO_BUMP_TOKENis configured/observed.The complete 35-item matrix, including suggested contributor replies, was produced during the integration review. No source issue or PR has been commented on or closed.
Attribution
Original authors are preserved on cherry-picked/reapplied topic commits. Reimplemented documentation carries
Co-authored-bytrailers.Validation
Uninterrupted final local run: 52/52 maintained commands returned exit 0 on Python 3.14.7 with Pillow 12.1.1, Playwright 1.62.0, and Chromium 151.0.7922.34. The paint oracle rendered 153 files with 0 findings/0 notes; skin lint checked 153 files with 0 findings; geometry checked 155 files with 0 findings; screenshot freshness matched all 39 canonical sources; README thumbnail freshness matched all 40 rendered previews.
verify-doctor.pyreturned its expected non-strictWARNsummary (4 pass, 1 PNG-readiness warning) while still exiting 0; both pinned Playwright render gates passed in the same run. Changed-path tests also pass under Python 3.12.14 with Pillow 12.1.1.GitHub current-head verification for
05c71c3: 9/9 checks passed (eight repository CI jobs plus Greptile), merge stateCLEAN, Greptile 5/5 with no concrete defect, and zero unresolved review threads.The pushed branch README was loaded live from GitHub at 1440×1000 and 390×844: both returned HTTP 200, all 42 image references resolved to the expected 40 unique WebPs with zero broken previews, and the preview link opened the full PNG path. The gallery deployment is intentionally unverified until merge triggers the Pages workflow.
Exact maintained commands — all passed
Additional review checks:
References after merge
After merge and explicit maintainer approval, this PR is intended to supersede contributor PRs #153, #147, #146, #138, and #52; partially supersede the accepted documentation portions of #163 and #145; and address issues #88, #77, #152, and #149. These are deliberately non-closing references so no contributor work is closed before the integration branch lands.
Remaining maintainer decisions
AUTO_BUMP_TOKENwith repo/workflow scope before merging; the current secret inventory does not contain it, and merged ci(release): bump plugin versions on main after merge, not in PRs #172 depends on it for the post-merge version bump.