Fix conflicting short options by markalexander · Pull Request #858 · cargo-lambda/cargo-lambda · GitHub
Skip to content

Fix conflicting short options - #858

Merged
calavera merged 2 commits into
cargo-lambda:mainfrom
markalexander:fix-conflicting-short-options
May 15, 2025
Merged

calavera merged 2 commits into
cargo-lambda:mainfrom
markalexander:fix-conflicting-short-options

Conversation

@markalexander

@markalexander markalexander commented May 8, 2025 •

Copy link
Copy Markdown
Contributor

Currently, a couple of the short options for the invoke subcommand are in conflict.

Just to be sure, I went through all the subcommand short options to see if there were any others:

 Option build deploy watch init invoke new system
-a — alias invoke-address — ⛔️ invoke-address / alias — —
-c compiler — — — — — —
-h help help help help help help help
-i include include — — — — —
-j jobs — jobs — — — —
-l lambda-dir lambda-dir — — — — —
-m — — — — — — manifest-path
-o output-format output-format — open output-format open output-format
-p package profile package — ⛔️ invoke-port / profile — package
-q quiet — quiet — — — —
-r release region release — region — —
-v verbose verbose verbose verbose verbose verbose verbose
-w — — wait — — — —
-x context context context context context context context
-y — — — no-interactive — no-interactive —
-A — — — — data-ascii — —
-E — — — — data-example — —
-F features — features — data-file — —
-P — — invoke-port — — — —
-R — — — — remote — —
-Z flag — flag — — — —

As you can see, it's just -a and -p on invoke that are a problem.

I updated:

  • --invoke-port on invoke to use -P (so that it matches with e.g. the watch subcommand); and
  • --invoke-address on invoke to use -A (to match -P); and
  • --invoke-address on watch to use -A (to match the two above).

Fixes #857.

@calavera calavera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlizen

jlizen commented May 15, 2025

Copy link
Copy Markdown
Contributor

Was this intended to be merged @calavera ?

@calavera

Copy link
Copy Markdown
Collaborator

oh, yeah, sorry about that. Merging!

@calavera
calavera merged commit 7afc937 into cargo-lambda:main May 15, 2025
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 15, 2025
@markalexander
markalexander deleted the fix-conflicting-short-options branch September 25, 2025 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflicting/missing short options on invoke

3 participants