Summary

The following content is AI-generated and provides a summary of the pull request:

Fix Malware Scan Status Stuck at Scanning After Draft Activation

Bug Fix

🐛 Resolves a race condition where activating a draft entity before the async malware scan completes causes the attachment to remain permanently stuck at status: Scanning. The fix ensures scan results are written to all candidate entities (both draft and active tables), so the correct table is updated regardless of when draft activation occurs. This also eliminates duplicate scanning that previously occurred for draft-enabled entities.

Root Cause

scanAttachment() selected the attachment row before the scan and updated only that same entity after. If the draft was activated during the scan, the draft row was deleted and the update hit 0 rows, leaving the active entity stuck at Scanning forever.

Changes

• DefaultAttachmentMalwareScanner.java: Refactored scanAttachment() into two distinct phases:

  1. Find & scan: locate the first entity containing the attachment and scan its content (once, not twice).
  2. Update all candidates: write the scan result to every candidate entity (both draft and active tables). An update against a table with no matching row is a harmless 0-row no-op.

  Extracted helpers findAndScanAttachment() and validateAndFilter() to support this split logic.

• DefaultAttachmentMalwareScannerTest.java: Updated existing tests to reflect that scanning and attachment service reads now happen once instead of twice. Added two new test cases:

  • scanResultWrittenToAllEntitiesEvenIfDraftDeletedDuringScanning — verifies the race condition scenario is handled correctly.
  • noScanOrUpdateWhenAttachmentNotFoundInAnyEntity — verifies no scan or update occurs when the attachment is not found in any entity.

Jira Issues

GitHub Issues:

• #770: Malware scan status stuck at 'Scanning' when draft is activated before async scan completes

• 🔄 Regenerate and Update Summary
• ✏️ Insert as PR Description (deletes this comment)
• 🗑️ Delete comment

💌 Have ideas or want to contribute? Create an issue and share your thoughts with us!
📑 Check out the documentation for more information.
📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

Made with ❤️ by Hyperspace.