Bookshop Sample#672
Conversation
Hey @Schmarvinius :) |
lisajulia
left a comment
There was a problem hiding this comment.
Additionally, I have these requests:
- Can you also add the README.md already? Then I would test to run this with the instructions you give there? Thanks :)
- Since this is a sample application, it then replaces the sample application that is currently in cap-notebook, right? If so, remove the cap-notebook folder then, please.
lisajulia
left a comment
There was a problem hiding this comment.
Thanks for fixing everything;
apart from the last comment about I actually have an issue with running the bookshop:
For me, neither http://localhost:8080/index.html#Books-manage nor http://localhost:8080/index.html#Books-display load, they stayed like this for some minutes now:


I suppose you don't have that problem, do you?
Possibly we can have a look at that together...
|
@adamandre79 or @mofterdinger: Can you have a look at this PR? We have replaced the old cap-notebook sample with a lean version of the bookshop so all plugins (across node and java) are aligned. |
|
@maxieckert-sap or @KoblerS: Can you have a look at this PR? @Schmarvinius has replaced the old cap-notebook sample with a lean version of the bookshop so all plugins (across node and java) are aligned. |

I added the bookshop as a sample of how attachments can be implemented.