{{ message }}
chore: working sample without cap-js#89
Open
Schmarvinius wants to merge 1 commit into
Open
Conversation
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR removes the @cap-js/ai Node.js dependency and cds-feature-recommendations Java artifact, replacing them with a manually-maintained recommendations.cds model and a new com.sap.cds/ai import path. There are two correctness issues in the new recommendations.cds that need attention: the association on condition and the non-standard @UI.Recommendations annotation — please verify both compile and produce the expected Fiori Elements behavior before merging.
PR Bot Information
Version: 1.26.0
- LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
pull_request.opened - File Content Strategy: Full file content
- Correlation ID:
ebd21fad-ab7e-44fd-93d4-6d77b437393e
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
@cap-js/aiDependency from Bookshop SampleRefactor
♻️ Refactored the bookshop sample to eliminate the
@cap-js/aiNode.js package dependency, replacing its auto-generated compile-time enhancements with manual CDS model definitions.Changes
samples/bookshop/.cdsrc.json: Removed theAICoreservice model reference pointing to@cap-js/ai/srv/AICoreServiceand thecdsc.moduleLookupDirectoriesconfiguration block.samples/bookshop/package.json: Removed@cap-js/aifrom thedependenciessection.samples/bookshop/package-lock.json: Removed the@cap-js/aipackage entry and its resolved metadata.samples/bookshop/pom.xml: Removed thecds-feature-recommendationsMaven dependency from the dependency management section.samples/bookshop/srv/pom.xml: Removed thecds-feature-recommendationsMaven dependency from the service module.samples/bookshop/srv/ai-core-service.cds: Updated theAICoreimport source from@cap-js/ai/srv/AICoreServicetocom.sap.cds/ai.samples/bookshop/srv/recommendations.cds(new): Added a manually defined CDS model that replicates the recommendations structure previously auto-generated by the@cap-js/aiplugin. This includes theBooks_Recommendationsvirtual entity with fields forgenre_IDandcurrency_code, a navigation property extension onAdminService.Books, and the@UI.Recommendationsannotation.PR Bot Information
Version:
1.26.0pull_request.openedebd21fad-ab7e-44fd-93d4-6d77b437393eanthropic--claude-4.6-sonnet